From: Andrew Lunn <andrew@lunn.ch>
To: Fabio Estevam <festevam@gmail.com>
Cc: kuba@kernel.org, davem@davemloft.net, olteanv@gmail.com,
netdev@vger.kernel.org, "Steffen Bätz" <steffen@innosonix.de>,
"Fabio Estevam" <festevam@denx.de>
Subject: Re: [PATCH v3 net-next] net: dsa: mv88e6xxx: Add RGMII delay to 88E6320
Date: Fri, 28 Oct 2022 20:43:54 +0200 [thread overview]
Message-ID: <Y1wi6t4Cu0R7qFxp@lunn.ch> (raw)
In-Reply-To: <20221028163158.198108-1-festevam@gmail.com>
On Fri, Oct 28, 2022 at 01:31:58PM -0300, Fabio Estevam wrote:
> From: Steffen Bätz <steffen@innosonix.de>
>
> Currently, the .port_set_rgmii_delay hook is missing for the 88E6320
> family, which causes failure to retrieve an IP address via DHCP.
>
> Add mv88e6320_port_set_rgmii_delay() that allows applying the RGMII
> delay for ports 2, 5, and 6, which are the only ports that can be used
> in RGMII mode.
>
> Tested on a custom i.MX8MN board connected to an 88E6320 switch.
>
> This change also applies safely to the 88E6321 variant.
>
> The only difference between 88E6320 versus 88E6321 is the temperature
> grade and pinout.
>
> They share exactly the same MDIO register map for ports 2, 5, and 6,
> which are the only ports that can be used in RGMII mode.
>
> Signed-off-by: Steffen Bätz <steffen@innosonix.de>
> [fabio: Improved commit log and extended it to mv88e6321_ops]
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2022-10-28 18:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 16:31 [PATCH v3 net-next] net: dsa: mv88e6xxx: Add RGMII delay to 88E6320 Fabio Estevam
2022-10-28 18:43 ` Andrew Lunn [this message]
2022-11-01 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1wi6t4Cu0R7qFxp@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=steffen@innosonix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).