From: Leon Romanovsky <leon@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Guangbin Huang <huangguangbin2@huawei.com>,
Sean Anderson <sean.anderson@seco.com>, Tom Rix <trix@redhat.com>,
Tonghao Zhang <xiangxia.m.yue@gmail.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Marco Bonelli <marco@mebeim.net>
Subject: Re: [PATCH net-next v1] ethtool: ethtool_get_drvinfo: populate drvinfo fields even if callback exits
Date: Thu, 10 Nov 2022 19:20:51 +0200 [thread overview]
Message-ID: <Y20y8yDgWH42LjMp@unreal> (raw)
In-Reply-To: <20221110090127.0d729f05@kernel.org>
On Thu, Nov 10, 2022 at 09:01:27AM -0800, Jakub Kicinski wrote:
> On Thu, 10 Nov 2022 11:11:38 +0200 Leon Romanovsky wrote:
> > I will be happy to see such patch and will review it, but can't add sign-off
> > as I'm not netdev maintainer.
>
> Did we finish the version removal work? :S
Good point :)
>
> Personally I'd rather direct any effort towards writing a checkpatch /
> cocci / python check that catches new cases than cleaning up the pile
> of drivers we have. A lot of which are not actively used..
I thought about this too, but came to conclusion what first step is to
remove "version" from in-kernel API. It will reduce drastically desire
to add driver version to new drivers.
"There is no shame in doing the right thing, even if its too late.".
BTW, I hope that we all learned that allowing drivers to return free
string to users will always lead to disaster.
Thanks
next prev parent reply other threads:[~2022-11-10 17:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 3:57 [PATCH net-next v1] ethtool: ethtool_get_drvinfo: populate drvinfo fields even if callback exits Vincent Mailhol
2022-11-09 17:52 ` Leon Romanovsky
2022-11-09 20:26 ` Jakub Kicinski
2022-11-10 8:34 ` Vincent MAILHOL
2022-11-10 9:11 ` Leon Romanovsky
2022-11-10 11:43 ` Vincent MAILHOL
2022-11-10 12:00 ` Leon Romanovsky
2022-11-10 15:53 ` Vincent MAILHOL
2022-11-10 17:22 ` Leon Romanovsky
2022-11-10 13:41 ` Andrew Lunn
2022-11-10 17:01 ` Jakub Kicinski
2022-11-10 17:20 ` Leon Romanovsky [this message]
2022-11-11 6:43 ` Vincent MAILHOL
2022-11-11 16:13 ` Leon Romanovsky
2022-11-10 16:59 ` Jakub Kicinski
2022-11-10 17:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y20y8yDgWH42LjMp@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=huangguangbin2@huawei.com \
--cc=kuba@kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=marco@mebeim.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.anderson@seco.com \
--cc=trix@redhat.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).