From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB7E1C4332F for ; Thu, 10 Nov 2022 18:50:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229669AbiKJSuI (ORCPT ); Thu, 10 Nov 2022 13:50:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229559AbiKJSuH (ORCPT ); Thu, 10 Nov 2022 13:50:07 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4628A14028 for ; Thu, 10 Nov 2022 10:50:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QKdGnCKxpuTh9fhvavU8cWMge7d1DhtKAJibrny01yg=; b=KQw0ZO6ZcEBYnKesCL60YxJaNh rY84E1GhkPUwTYg2l3ja9XdzsluWi9Agu3xNtH10AVRtlHloAGWlLWPJRHl6M3S6jE3Igl+st17pm sUI4EKhWwOfnpVpqKQXKlATlahV4LvRnw7a4l7EEwql8YLckSc8LJvFYOGi8ORE5Op/d01GMjgvQq 7gOexK4sdHiPkpElv1z+MHqB4jcU+qv9teEhg+EzMRMpOQXg4caHVjOXG9h4Lxj6baarMmRZ2Ff51 1h5xM5m1JqDww24hjEESPFSfGyYKxKM8AHG06Kamx8/V7FUy2v3f6B+2jYfjYhyr3Dx/FNfTsFj3P XcppuzMg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35208) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1otCcm-0005yV-Dv; Thu, 10 Nov 2022 18:50:04 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1otCcl-0006r4-QG; Thu, 10 Nov 2022 18:50:03 +0000 Date: Thu, 10 Nov 2022 18:50:03 +0000 From: "Russell King (Oracle)" To: Felix Fietkau Cc: netdev@vger.kernel.org, Matthias Brugger , Vladimir Oltean , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next v2 00/12] Multiqueue + DSA untag support + fixes for mtk_eth_soc Message-ID: References: <20221109163426.76164-1-nbd@nbd.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221109163426.76164-1-nbd@nbd.name> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Felix, Not directly related to your patch series, but as you seem to be tinkering with the driver, it seems appropriate to ask. Are you using hardware that uses RGMII? If not, do you know anyone who is? It would be good to fix mtk_mac_config(), specifically the use of state->speed therein - see the FIXME that I placed in that function. Honestly, I think this code is broken, since if the RGMII interface speed changes, the outer if() won't allow this code path to be re-executed (since mac->interface will be the same as state->interface for speed changes.) It would be nice to get rid of that, because this is the very last pre-March 2020 legacy ethernet driver, and it's marked as such for this very reason. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!