From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7350EC43217 for ; Wed, 2 Nov 2022 08:27:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230357AbiKBI1B (ORCPT ); Wed, 2 Nov 2022 04:27:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230309AbiKBI05 (ORCPT ); Wed, 2 Nov 2022 04:26:57 -0400 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2FEB822515; Wed, 2 Nov 2022 01:26:57 -0700 (PDT) Date: Wed, 2 Nov 2022 09:26:52 +0100 From: Pablo Neira Ayuso To: "Jason A. Donenfeld" Cc: netdev@vger.kernel.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Julian Anastasov , Simon Horman , stable@vger.kernel.org Subject: Re: [PATCH] ipvs: use explicitly signed chars Message-ID: References: <20221026123216.1575440-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221026123216.1575440-1-Jason@zx2c4.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Oct 26, 2022 at 02:32:16PM +0200, Jason A. Donenfeld wrote: > The `char` type with no explicit sign is sometimes signed and sometimes > unsigned. This code will break on platforms such as arm, where char is > unsigned. So mark it here as explicitly signed, so that the > todrop_counter decrement and subsequent comparison is correct. Applied, thanks