From: Petr Vorel <pvorel@suse.cz>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
"Michal Kubecek" <mkubecek@suse.cz>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"David Ahern" <dsahern@gmail.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Xin Long" <lucien.xin@gmail.com>,
"Vasiliy Kulikov" <segoon@openwall.com>,
"Hideaki YOSHIFUJI" <yoshfuji@linux-ipv6.org>
Subject: ping (iputils) review (call for help)
Date: Thu, 3 Nov 2022 12:30:08 +0100 [thread overview]
Message-ID: <Y2OmQDjtHmQCHE7x@pevik> (raw)
Hi,
I'm sorry to bother you about userspace. I'm preparing new iputils release and
I'm not sure about these two patches. As there has been many regressions,
review from experts is more than welcome.
If you have time to review them, it does not matter if you post your
comments/RBT in github or here (as long as you keep Cc me so that I don't
overlook it).
BTW I wonder if it make sense to list Hideaki YOSHIFUJI as NETWORKING
IPv4/IPv6 maintainer. If I'm not mistaken, it has been a decade since he was active.
* ping: Call connect() before sending/receiving
https://github.com/iputils/iputils/pull/391
=> I did not even knew it's possible to connect to ping socket, but looks like
it works on both raw socket and on ICMP datagram socket.
* ping: revert "ping: do not bind to device when destination IP is on device
https://github.com/iputils/iputils/pull/396
=> the problem has been fixed in mainline and stable/LTS kernels therefore I
suppose we can revert cc44f4c as done in this PR. It's just a question if we
should care about people who run new iputils on older (unfixed) kernels.
Kind regards,
Petr
next reply other threads:[~2022-11-03 11:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 11:30 Petr Vorel [this message]
2022-11-03 15:43 ` ping (iputils) review (call for help) Xin Long
2022-11-03 17:24 ` Petr Vorel
2022-11-03 20:27 ` Xin Long
2022-11-09 16:25 ` David Ahern
2022-11-09 22:01 ` Petr Vorel
2022-11-10 11:13 ` Hideaki Yoshifuji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2OmQDjtHmQCHE7x@pevik \
--to=pvorel@suse.cz \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lucien.xin@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=segoon@openwall.com \
--cc=toke@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).