From: Jiri Olsa <olsajiri@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: olsajiri@gmail.com, ast@kernel.org, daniel@iogearbox.net,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, bjorn@kernel.org, toke@redhat.com,
David.Laight@aculab.com, rostedt@goodmis.org
Subject: Re: [PATCH 0/2] bpf: Yet another approach to fix the BPF dispatcher thing
Date: Thu, 3 Nov 2022 15:48:51 +0100 [thread overview]
Message-ID: <Y2PU01h0hy+6dI0J@krava> (raw)
In-Reply-To: <20221103120012.717020618@infradead.org>
On Thu, Nov 03, 2022 at 01:00:12PM +0100, Peter Zijlstra wrote:
> Hi!
>
> Even thought the __attribute__((patchable_function_entry())) solution to the
> BPF dispatcher woes works, it turns out to not be supported by the whole range
> of ageing compilers we support. Specifically this attribute seems to be GCC-8
> and later.
>
> This is another approach -- using static_call() to rewrite the dispatcher
> function. I've compile tested this on:
>
> x86_64 (inline static-call support)
> i386 (out-of-line static-call support)
> aargh64 (no static-call support)
>
> A previous version was tested and found working by Bjorn.
>
> It is split in two patches; first reverting the current approach and then
> introducing the new for ease of review.
>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2022-11-03 14:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 12:00 [PATCH 0/2] bpf: Yet another approach to fix the BPF dispatcher thing Peter Zijlstra
2022-11-03 12:00 ` [PATCH 1/2] bpf: Revert ("Fix dispatcher patchable function entry to 5 bytes nop") Peter Zijlstra
2022-11-03 12:00 ` [PATCH 2/2] bpf: Convert BPF_DISPATCHER to use static_call() (not ftrace) Peter Zijlstra
2022-11-14 17:36 ` Steven Rostedt
2022-11-03 13:42 ` [PATCH 0/2] bpf: Yet another approach to fix the BPF dispatcher thing Björn Töpel
2022-11-03 14:48 ` Jiri Olsa [this message]
2022-11-04 22:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2PU01h0hy+6dI0J@krava \
--to=olsajiri@gmail.com \
--cc=David.Laight@aculab.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).