From: Andrew Lunn <andrew@lunn.ch>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: dp83867: define ti,ledX-active-low properties
Date: Thu, 3 Nov 2022 23:17:30 +0100 [thread overview]
Message-ID: <Y2Q9+qqwRqEu5btz@lunn.ch> (raw)
In-Reply-To: <20221103143118.2199316-2-linux@rasmusvillemoes.dk>
On Thu, Nov 03, 2022 at 03:31:17PM +0100, Rasmus Villemoes wrote:
> The dp83867 has three LED_X pins that can be used to drive LEDs. They
> are by default driven active high, but on some boards the reverse is
> needed. Add bindings to allow a board to specify that they should be
> active low.
Somebody really does need to finish the PHY LEDs via /sys/class/leds.
It looks like this would then be a reasonable standard property:
active-low, not a vendor property.
Please help out with the PHY LEDs patches.
Andrew
next prev parent reply other threads:[~2022-11-03 22:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 14:31 [PATCH 0/2] net: phy: dp83867: add DT bindings and support for active low LEDs Rasmus Villemoes
2022-11-03 14:31 ` [PATCH 1/2] dt-bindings: dp83867: define ti,ledX-active-low properties Rasmus Villemoes
2022-11-03 22:17 ` Andrew Lunn [this message]
2022-11-04 7:17 ` Rasmus Villemoes
2022-11-04 8:11 ` [PATCH 1/2] dt-bindings: dp83867: define ti, ledX-active-low properties Alexander Stein
2022-11-04 13:21 ` [PATCH 1/2] dt-bindings: dp83867: define ti,ledX-active-low properties Andrew Lunn
2022-11-03 14:31 ` [PATCH 2/2] net: phy: dp83867: implement support for ti,ledX-active-low bindings Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2Q9+qqwRqEu5btz@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=linux@rasmusvillemoes.dk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).