From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 222B0C433FE for ; Fri, 4 Nov 2022 11:24:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231635AbiKDLY5 (ORCPT ); Fri, 4 Nov 2022 07:24:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231605AbiKDLYy (ORCPT ); Fri, 4 Nov 2022 07:24:54 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF0832B199 for ; Fri, 4 Nov 2022 04:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GB/esQIKHmGf0biwlVHerM2XyaCQgmWfe0zE5BD7I0w=; b=GWf0VPdERxJwcCRyJWop6lSyel A5qdjPqrJXsFHkwwqQEHnC4gMGmXCeo8AwViDSunfElWDSWYQEGB0+rj2eQK02lVBqeIdMeCNRl+/ oT+1QTVXhJBX0sKMNUdIkOm9apzzkrQwR4WGKARsCmQGp8ETFiLcUgwK3cKEKtBACYYW9e2cQXcNv 0SSxUeE0rRPQG7q1hOyeQDXn3V8qWKdXI0M2yl7arxVG7zuQ4aoqJdzjaHE7MUEnOjXFMnAiUqzu7 oa+tH5CRvVTzn5EW2ksiYrV0xH25LqRYUgtAPr9cypkEYR+CUy48U+Onk/i/v6NEsqivCsB8Q/yDJ HtonTtXw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35102) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oquoY-0007VD-Vh; Fri, 04 Nov 2022 11:24:47 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oquoW-0000qa-1k; Fri, 04 Nov 2022 11:24:44 +0000 Date: Fri, 4 Nov 2022 11:24:44 +0000 From: "Russell King (Oracle)" To: Vladimir Oltean , Florian Fainelli Cc: netdev@vger.kernel.org, Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Heiner Kallweit , Sean Anderson , Colin Foster , Andrew Lunn , Vivien Didelot , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH net-next 4/4] net: dsa: remove phylink_validate() method Message-ID: References: <20221101114806.1186516-1-vladimir.oltean@nxp.com> <20221101114806.1186516-5-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221101114806.1186516-5-vladimir.oltean@nxp.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Nov 01, 2022 at 01:48:06PM +0200, Vladimir Oltean wrote: > As of now, all DSA drivers use phylink_generic_validate() and there is > no known use case remaining for a driver-specific link mode validation > procedure. As such, remove this DSA operation and let phylink determine > what is supported based on config->mac_capabilities, which all drivers > provide. > > Signed-off-by: Vladimir Oltean > --- > Not all DSA drivers provide config->mac_capabilities, for example > mv88e6060, lan9303 and vsc73xx don't. However, there have been users of > those drivers on recent kernels and no one reported that they fail to > establish a link, so I'm guessing that they work (somehow). But I must > admit I don't understand why phylink_generic_validate() works when > mac_capabilities=0. Anyway, these drivers did not provide a > phylink_validate() method before and do not provide one now, so nothing > changes for them. There is one remaining issue that needs to be properly addressed, which is the bcm_sf2 driver, which is basically buggy. The recent kernel build bot reports reminded me of this. I've tried talking to Florian about it, and didn't make much progress, so I'm carrying a patch in my tree which at least makes what is provided to phylink correct. See http://git.armlinux.org.uk/cgit/linux-arm.git/commit/?h=net-queue&id=63d77c1f9db167fd74994860a4a899df5c957aab and all the FIXME comments in there. This driver really needs to be fixed before we kill DSA's phylink_validate method (although doing so doesn't change anything in mainline, but will remove my reminder that bcm_sf2 is still technically broken.) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!