From: Andrew Lunn <andrew@lunn.ch>
To: Sriranjani P <sriranjani.p@samsung.com>
Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com,
richardcochran@gmail.com, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Chandrasekar R <rcsekar@samsung.com>,
Suresh Siddha <ssiddha@tesla.com>
Subject: Re: [PATCH 2/4] net: stmmac: dwc-qos: Add FSD EQoS support
Date: Fri, 4 Nov 2022 16:32:08 +0100 [thread overview]
Message-ID: <Y2UweBsUDvrU9keT@lunn.ch> (raw)
In-Reply-To: <20221104120517.77980-3-sriranjani.p@samsung.com>
> For FSD SoC, a mux switch is needed between internal and external clocks.
> By default after reset internal clock is used but for receiving packets
> properly, external clock is needed. Mux switch to external clock happens
> only when the external clock is present.
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -3831,6 +3831,9 @@ static int __stmmac_open(struct net_device *dev,
> netif_tx_start_all_queues(priv->dev);
> stmmac_enable_all_dma_irq(priv);
>
> + if (priv->plat->rxmux_setup)
> + priv->plat->rxmux_setup(priv->plat->bsp_priv, true);
> +
> return 0;
>
> irq_error:
> @@ -3884,6 +3887,9 @@ static int stmmac_release(struct net_device *dev)
> struct stmmac_priv *priv = netdev_priv(dev);
> u32 chan;
>
> + if (priv->plat->rxmux_setup)
> + priv->plat->rxmux_setup(priv->plat->bsp_priv, false);
> +
Is this the code which is deciding if the external clock is present? So when somebody called
'ip link set eth42 up'?
Where is the external clock coming from?
Andrew
next prev parent reply other threads:[~2022-11-04 15:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221104115833epcas5p31f68ef0a192e0d6678d2e2a0b3b89c4e@epcas5p3.samsung.com>
2022-11-04 12:05 ` [PATCH 0/4] net: stmmac: dwc-qos: Add FSD EQoS support Sriranjani P
2022-11-04 12:05 ` [PATCH 1/4] dt-bindings: net: Add EQoS compatible for FSD SoC Sriranjani P
2022-11-04 12:48 ` Krzysztof Kozlowski
2022-11-16 6:21 ` Sriranjani P
2022-11-04 12:05 ` [PATCH 2/4] net: stmmac: dwc-qos: Add FSD EQoS support Sriranjani P
2022-11-04 15:25 ` Andrew Lunn
2022-11-16 6:24 ` Sriranjani P
2022-11-04 15:32 ` Andrew Lunn [this message]
2022-11-04 12:05 ` [PATCH 3/4] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC Sriranjani P
2022-11-04 12:45 ` Krzysztof Kozlowski
2022-11-04 12:47 ` Krzysztof Kozlowski
2022-11-16 6:22 ` Sriranjani P
2022-11-04 12:05 ` [PATCH 4/4] arm64: dts: fsd: Add Ethernet support for PERIC " Sriranjani P
2022-11-04 12:46 ` Krzysztof Kozlowski
2022-11-16 6:17 ` Sriranjani P
2022-11-04 15:34 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2UweBsUDvrU9keT@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=rcsekar@samsung.com \
--cc=richardcochran@gmail.com \
--cc=sriranjani.p@samsung.com \
--cc=ssiddha@tesla.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).