From: Andrew Lunn <andrew@lunn.ch>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: richardcochran@gmail.com, bagasdotme@gmail.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next v3] net: ethernet: Simplify bool conversion
Date: Fri, 4 Nov 2022 16:46:41 +0100 [thread overview]
Message-ID: <Y2Uz4Sea8xekgpyR@lunn.ch> (raw)
In-Reply-To: <20221104063731.84008-1-yang.lee@linux.alibaba.com>
On Fri, Nov 04, 2022 at 02:37:31PM +0800, Yang Li wrote:
> The result of 'scaled_ppm < 0' is Boolean, and the question mark
> expression is redundant, remove it to clear the below warning:
>
> ./drivers/net/ethernet/renesas/rcar_gen4_ptp.c:32:40-45: WARNING: conversion to bool not needed here
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2729
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>
> change in v3:
> --According to Richard's suggestion, to preserve reverse Christmas tree order.
Don't send a new version of a patch for at least 24 hours.
https://docs.kernel.org/process/maintainer-netdev.html#tl-dr
People need time to review your patch and suggest how to make it
better.
Andrew
prev parent reply other threads:[~2022-11-04 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 6:37 [PATCH -next v3] net: ethernet: Simplify bool conversion Yang Li
2022-11-04 15:46 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2Uz4Sea8xekgpyR@lunn.ch \
--to=andrew@lunn.ch \
--cc=abaci@linux.alibaba.com \
--cc=bagasdotme@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).