From: Leon Romanovsky <leon@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org,
edumazet@google.com, pabeni@redhat.com, gospo@broadcom.com,
pavan.chebbi@broadcom.com
Subject: Re: [PATCH net-next 1/3] bnxt_en: refactor VNIC RSS update functions
Date: Mon, 7 Nov 2022 09:51:22 +0200 [thread overview]
Message-ID: <Y2i4+vudfY71/yn3@unreal> (raw)
In-Reply-To: <1667780192-3700-2-git-send-email-michael.chan@broadcom.com>
On Sun, Nov 06, 2022 at 07:16:30PM -0500, Michael Chan wrote:
> From: Edwin Peer <edwin.peer@broadcom.com>
>
> Extract common code into a new function. This will avoid duplication
> in the next patch, which changes the update algorithm for both the P5
> and legacy code paths.
>
> No functional changes.
>
> Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
> Signed-off-by: Michael Chan <michael.chan@broadcom.com>
> ---
> drivers/net/ethernet/broadcom/bnxt/bnxt.c | 34 +++++++++++------------
> 1 file changed, 16 insertions(+), 18 deletions(-)
<...>
> +static void
> +__bnxt_hwrm_vnic_set_rss(struct bnxt *bp, struct hwrm_vnic_rss_cfg_input *req,
> + struct bnxt_vnic_info *vnic)
The "__" prefix in __func_name() usually means in kernel that this function
is locked externally.
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2022-11-07 7:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 0:16 [PATCH net-next 0/3] bnxt_en: Updates Michael Chan
2022-11-07 0:16 ` [PATCH net-next 1/3] bnxt_en: refactor VNIC RSS update functions Michael Chan
2022-11-07 7:51 ` Leon Romanovsky [this message]
2022-11-07 0:16 ` [PATCH net-next 2/3] bnxt_en: update RSS config using difference algorithm Michael Chan
2022-11-07 7:51 ` Leon Romanovsky
2022-11-07 0:16 ` [PATCH net-next 3/3] bnxt_en: Add a non-real time mode to access NIC clock Michael Chan
2022-11-07 7:51 ` Leon Romanovsky
2022-11-08 11:50 ` [PATCH net-next 0/3] bnxt_en: Updates patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2i4+vudfY71/yn3@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).