* [PATCH] ethernet: alteon: remove unused variable len
@ 2022-11-04 17:42 Colin Ian King
2022-11-07 6:47 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-11-04 17:42 UTC (permalink / raw)
To: Jes Sorensen, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, linux-acenic, netdev
Cc: kernel-janitors, linux-kernel
Variable len is being used to accumulate the skb_frag_size but it
is never used afterwards. The variable is redundant and can be
removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/ethernet/alteon/acenic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/alteon/acenic.c b/drivers/net/ethernet/alteon/acenic.c
index d7762da8b2c0..eafef84fe3be 100644
--- a/drivers/net/ethernet/alteon/acenic.c
+++ b/drivers/net/ethernet/alteon/acenic.c
@@ -2435,7 +2435,7 @@ static netdev_tx_t ace_start_xmit(struct sk_buff *skb,
} else {
dma_addr_t mapping;
u32 vlan_tag = 0;
- int i, len = 0;
+ int i;
mapping = ace_map_tx_skb(ap, skb, NULL, idx);
flagsize = (skb_headlen(skb) << 16);
@@ -2454,7 +2454,6 @@ static netdev_tx_t ace_start_xmit(struct sk_buff *skb,
const skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
struct tx_ring_info *info;
- len += skb_frag_size(frag);
info = ap->skb->tx_skbuff + idx;
desc = ap->tx_ring + idx;
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ethernet: alteon: remove unused variable len
2022-11-04 17:42 [PATCH] ethernet: alteon: remove unused variable len Colin Ian King
@ 2022-11-07 6:47 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2022-11-07 6:47 UTC (permalink / raw)
To: Colin Ian King
Cc: Jes Sorensen, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, linux-acenic, netdev, kernel-janitors, linux-kernel
On Fri, Nov 04, 2022 at 05:42:15PM +0000, Colin Ian King wrote:
> Variable len is being used to accumulate the skb_frag_size but it
> is never used afterwards. The variable is redundant and can be
> removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/net/ethernet/alteon/acenic.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
net patches should have target in their title "[PATCH net-next] ...".
It is applicable to all your net patches.
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-07 6:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-04 17:42 [PATCH] ethernet: alteon: remove unused variable len Colin Ian King
2022-11-07 6:47 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).