From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com, idosch@idosch.org, bigeasy@linutronix.de,
imagedong@tencent.com, kuniyu@amazon.com, petrm@nvidia.com
Subject: Re: [patch net-next 1/2] net: introduce a helper to move notifier block to different namespace
Date: Tue, 8 Nov 2022 07:53:39 +0100 [thread overview]
Message-ID: <Y2n881qPpY9J8MQ0@nanopsycho> (raw)
In-Reply-To: <20221107202937.6ec5474c@kernel.org>
Tue, Nov 08, 2022 at 05:29:37AM CET, kuba@kernel.org wrote:
>On Mon, 7 Nov 2022 15:52:12 +0100 Jiri Pirko wrote:
>> +void __move_netdevice_notifier_net(struct net *src_net, struct net *dst_net,
>> + struct notifier_block *nb)
>> +{
>> + __unregister_netdevice_notifier_net(src_net, nb);
>> + __register_netdevice_notifier_net(dst_net, nb, true);
>> +}
>
>'static' missing
Yep.
>
>> +void move_netdevice_notifier_net(struct net *src_net, struct net *dst_net,
>> + struct notifier_block *nb)
>> +{
>> + rtnl_lock();
>> + __move_netdevice_notifier_net(src_net, dst_net, nb);
>> + rtnl_unlock();
>> +}
>> +EXPORT_SYMBOL(move_netdevice_notifier_net);
>
>Do we need to export this? Maybe let's wait for a module user?
Ah, right.
next prev parent reply other threads:[~2022-11-08 6:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 14:52 [patch net-next 0/2] net: devlink: move netdev notifier block to dest namespace during reload Jiri Pirko
2022-11-07 14:52 ` [patch net-next 1/2] net: introduce a helper to move notifier block to different namespace Jiri Pirko
2022-11-08 4:29 ` Jakub Kicinski
2022-11-08 6:53 ` Jiri Pirko [this message]
2022-11-07 14:52 ` [patch net-next 2/2] net: devlink: move netdev notifier block to dest namespace during reload Jiri Pirko
2022-11-07 16:52 ` Ido Schimmel
2022-11-07 17:24 ` Jiri Pirko
2022-11-08 8:11 ` Ido Schimmel
2022-11-08 12:59 ` Jiri Pirko
2022-11-08 13:07 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2n881qPpY9J8MQ0@nanopsycho \
--to=jiri@resnulli.us \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@idosch.org \
--cc=imagedong@tencent.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox