From: Andrew Lunn <andrew@lunn.ch>
To: Lukasz Majewski <lukma@denx.de>
Cc: Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Subject: Re: [PATCH 2/9] net: dsa: mv88e6xxx: account for PHY base address offset in dual chip mode
Date: Tue, 8 Nov 2022 14:26:39 +0100 [thread overview]
Message-ID: <Y2pZD/3AQV1gjbFV@lunn.ch> (raw)
In-Reply-To: <20221108082330.2086671-3-lukma@denx.de>
On Tue, Nov 08, 2022 at 09:23:23AM +0100, Lukasz Majewski wrote:
> From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
>
> In dual chip mode (6250 family), not only global and port registers are
> shifted by sw_addr, but also the PHY addresses. Account for this in the
> IRQ mapping.
> +++ b/drivers/net/dsa/mv88e6xxx/smi.c
> @@ -186,5 +186,9 @@ int mv88e6xxx_smi_init(struct mv88e6xxx_chip *chip,
> if (chip->smi_ops->init)
> return chip->smi_ops->init(chip);
>
> + chip->phy_base_addr = chip->info->phy_base_addr;
> + if (chip->info->dual_chip)
> + chip->phy_base_addr += sw_addr;
> +
> return 0;
Again, reviewing first to last, i assume the will be a patch soon
implementing get_phy_address(), and it will have the same logic. Why
not call it here, a default implementation which returns
info->phy_base_addr, and a version for 6250 which returns sw_addr.
Andrew
next prev parent reply other threads:[~2022-11-08 13:26 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 8:23 [PATCH 0/9] net: dsa: Add support for mv88e6020 and mv88e6071 Lukasz Majewski
2022-11-08 8:23 ` [PATCH 1/9] net: dsa: allow switch drivers to override default slave PHY addresses Lukasz Majewski
2022-11-08 9:12 ` Vladimir Oltean
2022-11-08 10:34 ` Lukasz Majewski
2022-11-08 13:21 ` Andrew Lunn
2022-11-10 15:34 ` Lukasz Majewski
2022-11-10 22:05 ` Andrew Lunn
2022-11-14 8:51 ` Lukasz Majewski
2022-11-08 18:10 ` Florian Fainelli
2022-11-08 8:23 ` [PATCH 2/9] net: dsa: mv88e6xxx: account for PHY base address offset in dual chip mode Lukasz Majewski
2022-11-08 13:26 ` Andrew Lunn [this message]
2022-11-10 17:02 ` Lukasz Majewski
2022-11-08 8:23 ` [PATCH 3/9] net: dsa: mv88e6xxx: implement get_phy_address Lukasz Majewski
2022-11-08 9:12 ` Vladimir Oltean
2022-11-08 13:36 ` Andrew Lunn
2022-11-10 17:00 ` Lukasz Majewski
2022-11-11 21:38 ` Vladimir Oltean
2022-11-14 10:10 ` Lukasz Majewski
2022-11-10 16:37 ` Lukasz Majewski
2022-11-08 8:23 ` [PATCH 4/9] net: dsa: mv88e6xxx: add support for MV88E6020 switch Lukasz Majewski
2022-11-08 8:23 ` [PATCH 5/9] net: dsa: mv88e6xxx: Add support for MV88E6071 switch Lukasz Majewski
2022-11-08 8:23 ` [PATCH 6/9] net: dsa: marvell: Provide per device information about max frame size Lukasz Majewski
2022-11-08 13:47 ` Andrew Lunn
2022-11-10 15:36 ` Lukasz Majewski
2022-11-10 22:10 ` Andrew Lunn
2022-11-14 8:52 ` Lukasz Majewski
2022-11-08 8:23 ` [PATCH 7/9] net: dsa: mv88e6071: Define max frame size (2048 bytes) Lukasz Majewski
2022-11-08 13:49 ` Andrew Lunn
2022-11-10 15:42 ` Lukasz Majewski
2022-11-10 22:12 ` Andrew Lunn
2022-11-14 9:06 ` Lukasz Majewski
2022-11-08 8:23 ` [PATCH 8/9] net: dsa: mv88e6071: Provide struct mv88e6xxx_ops Lukasz Majewski
2022-11-08 8:23 ` [PATCH 9/9] net: dsa: mv88e6071: Set .set_max_frame_size callback Lukasz Majewski
2022-11-08 14:03 ` Andrew Lunn
2022-11-10 16:00 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2pZD/3AQV1gjbFV@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=lukma@denx.de \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).