From: Andrew Lunn <andrew@lunn.ch>
To: Lukasz Majewski <lukma@denx.de>
Cc: Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 6/9] net: dsa: marvell: Provide per device information about max frame size
Date: Tue, 8 Nov 2022 14:47:32 +0100 [thread overview]
Message-ID: <Y2pd9CFMzI5UZSiD@lunn.ch> (raw)
In-Reply-To: <20221108082330.2086671-7-lukma@denx.de>
On Tue, Nov 08, 2022 at 09:23:27AM +0100, Lukasz Majewski wrote:
> Different Marvell DSA switches support different size of max frame
> bytes to be sent.
>
> For example mv88e6185 supports max 1632B, which is now in-driver
> standard value. On the other hand - mv88e6071 supports 2048 bytes.
>
> As this value is internal and may be different for each switch IC
> new entry in struct mv88e6xxx_info has been added to store it.
>
> When the 'max_frame_size' is not defined (and hence zeroed by
> the kvzalloc()) the default of 1632 bytes is used.
I would prefer every entry states the value. That both simplifies the
code, and probably reduces the likelihood of somebody forgetting to
set it when adding a new chip.
Andrew
next prev parent reply other threads:[~2022-11-08 13:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 8:23 [PATCH 0/9] net: dsa: Add support for mv88e6020 and mv88e6071 Lukasz Majewski
2022-11-08 8:23 ` [PATCH 1/9] net: dsa: allow switch drivers to override default slave PHY addresses Lukasz Majewski
2022-11-08 9:12 ` Vladimir Oltean
2022-11-08 10:34 ` Lukasz Majewski
2022-11-08 13:21 ` Andrew Lunn
2022-11-10 15:34 ` Lukasz Majewski
2022-11-10 22:05 ` Andrew Lunn
2022-11-14 8:51 ` Lukasz Majewski
2022-11-08 18:10 ` Florian Fainelli
2022-11-08 8:23 ` [PATCH 2/9] net: dsa: mv88e6xxx: account for PHY base address offset in dual chip mode Lukasz Majewski
2022-11-08 13:26 ` Andrew Lunn
2022-11-10 17:02 ` Lukasz Majewski
2022-11-08 8:23 ` [PATCH 3/9] net: dsa: mv88e6xxx: implement get_phy_address Lukasz Majewski
2022-11-08 9:12 ` Vladimir Oltean
2022-11-08 13:36 ` Andrew Lunn
2022-11-10 17:00 ` Lukasz Majewski
2022-11-11 21:38 ` Vladimir Oltean
2022-11-14 10:10 ` Lukasz Majewski
2022-11-10 16:37 ` Lukasz Majewski
2022-11-08 8:23 ` [PATCH 4/9] net: dsa: mv88e6xxx: add support for MV88E6020 switch Lukasz Majewski
2022-11-08 8:23 ` [PATCH 5/9] net: dsa: mv88e6xxx: Add support for MV88E6071 switch Lukasz Majewski
2022-11-08 8:23 ` [PATCH 6/9] net: dsa: marvell: Provide per device information about max frame size Lukasz Majewski
2022-11-08 13:47 ` Andrew Lunn [this message]
2022-11-10 15:36 ` Lukasz Majewski
2022-11-10 22:10 ` Andrew Lunn
2022-11-14 8:52 ` Lukasz Majewski
2022-11-08 8:23 ` [PATCH 7/9] net: dsa: mv88e6071: Define max frame size (2048 bytes) Lukasz Majewski
2022-11-08 13:49 ` Andrew Lunn
2022-11-10 15:42 ` Lukasz Majewski
2022-11-10 22:12 ` Andrew Lunn
2022-11-14 9:06 ` Lukasz Majewski
2022-11-08 8:23 ` [PATCH 8/9] net: dsa: mv88e6071: Provide struct mv88e6xxx_ops Lukasz Majewski
2022-11-08 8:23 ` [PATCH 9/9] net: dsa: mv88e6071: Set .set_max_frame_size callback Lukasz Majewski
2022-11-08 14:03 ` Andrew Lunn
2022-11-10 16:00 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2pd9CFMzI5UZSiD@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=lukma@denx.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).