From: Hangbin Liu <liuhangbin@gmail.com>
To: Jay Vosburgh <j.vosburgh@gmail.com>
Cc: netdev@vger.kernel.org, oe-kbuild-all@lists.linux.dev,
kernel test robot <lkp@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Toppins <jtoppins@redhat.com>,
Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@gmail.com>,
Liang Li <liali@redhat.com>
Subject: Re: [PATCHv2 net] bonding: fix ICMPv6 header handling when receiving IPv6 messages
Date: Wed, 9 Nov 2022 10:23:31 +0800 [thread overview]
Message-ID: <Y2sPI+E8RgaM2ND5@Laptop-X1> (raw)
In-Reply-To: <202211082322.B7ILgv9S-lkp@intel.com>
On Wed, Nov 09, 2022 at 12:06:32AM +0800, kernel test robot wrote:
> All warnings (new ones prefixed by >>):
>
> drivers/net/bonding/bond_main.c: In function 'bond_na_rcv':
> >> drivers/net/bonding/bond_main.c:3242:77: warning: passing argument 4 of 'skb_header_pointer' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> 3242 | hdr = skb_header_pointer(skb, sizeof(struct ipv6hdr), sizeof(_hdr), &_hdr);
> | ^~~~~
Oh...When I post patches, I always rebuild the whole kernel. Maybe I missed
this warning as the build info passed to fast. I will only build the module
like the bot did in future...
I have post a new version to fix this.
> from drivers/net/bonding/bond_main.c:35:
> In function 'fortify_memcpy_chk',
> inlined from 'iph_to_flow_copy_v4addrs' at include/net/ip.h:566:2,
> inlined from 'bond_flow_ip' at drivers/net/bonding/bond_main.c:3983:3:
> include/linux/fortify-string.h:413:25: warning: call to '__read_overflow2_field' declared with attribute warning: detected read beyond size of field (2nd parameter); maybe use struct_group()? [-Wattribute-warning]
> 413 | __read_overflow2_field(q_size_field, size);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In function 'fortify_memcpy_chk',
> inlined from 'iph_to_flow_copy_v6addrs' at include/net/ipv6.h:900:2,
> inlined from 'bond_flow_ip' at drivers/net/bonding/bond_main.c:3993:3:
> include/linux/fortify-string.h:413:25: warning: call to '__read_overflow2_field' declared with attribute warning: detected read beyond size of field (2nd parameter); maybe use struct_group()? [-Wattribute-warning]
> 413 | __read_overflow2_field(q_size_field, size);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I will post another patch to fix this warning.
Thanks
Hangbin
prev parent reply other threads:[~2022-11-09 2:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 7:00 [PATCHv2 net] bonding: fix ICMPv6 header handling when receiving IPv6 messages Hangbin Liu
2022-11-08 13:50 ` Jonathan Toppins
2022-11-08 14:55 ` kernel test robot
2022-11-08 15:24 ` David Ahern
2022-11-08 16:06 ` kernel test robot
2022-11-09 2:23 ` Hangbin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2sPI+E8RgaM2ND5@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=j.vosburgh@gmail.com \
--cc=jtoppins@redhat.com \
--cc=kuba@kernel.org \
--cc=liali@redhat.com \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox