From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ADD6C433FE for ; Wed, 9 Nov 2022 08:18:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229645AbiKIIR7 (ORCPT ); Wed, 9 Nov 2022 03:17:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229662AbiKIIR6 (ORCPT ); Wed, 9 Nov 2022 03:17:58 -0500 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F8141BE81 for ; Wed, 9 Nov 2022 00:17:57 -0800 (PST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id A49765C00D5; Wed, 9 Nov 2022 03:17:54 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 09 Nov 2022 03:17:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1667981874; x=1668068274; bh=+LMneKv5k+OvBcSGWMWI6zNezFuN JguV2eEB7JZE7d0=; b=AVHwPJaJy+8als89XN/yVvV1/u1LMFKAajYrEytXN2TZ ABLrgCwT/ovG8U3hLbUPY3O0+oPGycmD4n6s2MykKtH6YFeBRJaZpobj61g5Ynii rVmMp7IJHsI0I2dVHrph+tFIJ8xTfJL36Bqr2Kch+DP1HDfT/SK6FH6XLuld7hO+ Xrkb8rxQo7AK9yh+/+hk9vob74cARuxYlld20kRL/R+LI4FF+oZwu6RhVE7AAsjV BB/8bhacdC7IoMKYYd1p76YuLSqqbC7hg3IBarj+BuYQtAwjaTA+zPLWFyCxIMfs rYjPiV67X012RdewMUQN3g/cP3z7Nn9orJawRH1uxQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrfedugdduvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnhepvddufeevkeehueegfedtvdevfefgudeifeduieefgfelkeehgeelgeejjeeg gefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih guohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Nov 2022 03:17:53 -0500 (EST) Date: Wed, 9 Nov 2022 10:17:51 +0200 From: Ido Schimmel To: Hangbin Liu Cc: netdev@vger.kernel.org, Guillaume Nault , David Ahern , Stephen Hemminger Subject: Re: [PATCH iproute2] ip: fix return value for rtnl_talk failures Message-ID: References: <20221108124344.192326-1-liuhangbin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221108124344.192326-1-liuhangbin@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Nov 08, 2022 at 08:43:44PM +0800, Hangbin Liu wrote: > Since my last commit "rtnetlink: add new function rtnl_echo_talk()" we > return the kernel rtnl exit code directly, which breaks some kernel > selftest checking. As there are still a lot of tests checking -2 as the > error return value, to keep backward compatibility, let's keep using > -2 for all the rtnl return values. > > Reported-by: Ido Schimmel > Fixes: 6c09257f1bf6 ("rtnetlink: add new function rtnl_echo_talk()") > Signed-off-by: Hangbin Liu Tested-by: Ido Schimmel