From: Leon Romanovsky <leon@kernel.org>
To: Yinjun Zhang <yinjun.zhang@corigine.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Chengtian Liu <chengtian.liu@corigine.com>,
HuanHuan Wang <huanhuan.wang@corigine.com>,
Louis Peens <louis.peens@corigine.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
oss-drivers <oss-drivers@corigine.com>,
Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH net-next v3 3/3] nfp: implement xfrm callbacks and expose ipsec offload feature to upper layer
Date: Wed, 9 Nov 2022 10:26:14 +0200 [thread overview]
Message-ID: <Y2tkJjdLLSWyTO3l@unreal> (raw)
In-Reply-To: <DM6PR13MB3705F170F1EB28EE34F0C503FC3E9@DM6PR13MB3705.namprd13.prod.outlook.com>
On Wed, Nov 09, 2022 at 06:58:44AM +0000, Yinjun Zhang wrote:
> On Mon, 7 Nov 2022 08:14:12 +0200, Leon Romanovsky wrote:
> > On Tue, Nov 01, 2022 at 12:02:48PM +0100, Simon Horman wrote:
> <...>
> > > +
> > > + /* General */
> > > + switch (x->props.mode) {
> > > + case XFRM_MODE_TUNNEL:
> > > + cfg->ctrl_word.mode = NFP_IPSEC_PROTMODE_TUNNEL;
> > > + break;
> > > + case XFRM_MODE_TRANSPORT:
> > > + cfg->ctrl_word.mode = NFP_IPSEC_PROTMODE_TRANSPORT;
> > > + break;
> > > + default:
> > > + nn_err(nn, "Unsupported mode for xfrm offload\n");
> >
> > There are no other modes.
>
> Sorry this comment was neglected, but I have to say this is a good practice to avoid
> newly introduced mode in future sneaking into HW while it's not supported.
There is a subtitle difference between not-existent flows and
not-supported ones. Good practice is to rely on upper level API to do
the right thing from the beginning.
Thanks
next prev parent reply other threads:[~2022-11-09 8:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 11:02 [PATCH net-next v3 0/3] nfp: IPsec offload support Simon Horman
2022-11-01 11:02 ` [PATCH net-next v3 1/3] nfp: extend capability and control words Simon Horman
2022-11-06 19:39 ` Leon Romanovsky
2022-11-01 11:02 ` [PATCH net-next v3 2/3] nfp: add framework to support ipsec offloading Simon Horman
2022-11-06 19:39 ` Leon Romanovsky
2022-11-01 11:02 ` [PATCH net-next v3 3/3] nfp: implement xfrm callbacks and expose ipsec offload feature to upper layer Simon Horman
2022-11-06 19:48 ` Leon Romanovsky
2022-11-07 9:50 ` Yinjun Zhang
2022-11-07 6:14 ` Leon Romanovsky
2022-11-07 9:46 ` Yinjun Zhang
2022-11-07 12:40 ` Leon Romanovsky
2022-11-08 1:28 ` Yinjun Zhang
2022-11-08 18:42 ` Leon Romanovsky
2022-11-09 6:51 ` Yinjun Zhang
2022-11-09 6:58 ` Yinjun Zhang
2022-11-09 8:26 ` Leon Romanovsky [this message]
2022-11-09 12:09 ` Yinjun Zhang
2022-11-09 12:24 ` Leon Romanovsky
2022-11-04 3:48 ` [PATCH net-next v3 0/3] nfp: IPsec offload support Jakub Kicinski
2022-11-05 15:27 ` Steffen Klassert
2022-11-05 17:25 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2tkJjdLLSWyTO3l@unreal \
--to=leon@kernel.org \
--cc=chengtian.liu@corigine.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=huanhuan.wang@corigine.com \
--cc=kuba@kernel.org \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=steffen.klassert@secunet.com \
--cc=yinjun.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).