Re: [PATCH (repost) net-next] sched: add extack for tfilter_notify

Jamal Hadi Salim
2022-11-10T01:52:54Z

TCA_XXX are local whereas NLMSGERR_ATTR_MSG global to the
netlink message. Does this mean to replicate TCA_NTF_EXT_ACK
for all objects when needed? (qdiscs, actions, etc).

cheers,
jamal

On Wed, Nov 9, 2022 at 6:53 AM Hangbin Liu <liuhangbin@gmail.com> wrote:
>
> On Tue, Nov 08, 2022 at 10:55:44AM -0800, Jakub Kicinski wrote:
> > My initial thought was to add an attribute type completely independent
> > of the attribute space defined in enum nlmsgerr_attrs, add it in the
> > TCA_* space. So for example add a TCA_NTF_WARN_MSG which will carry the
> > string message.
> >
> > We can also create a nest to carry the full nlmsgerr_attrs attributes
> > with their existing types (TCA_NTF_EXT_ACK?). Each nest gets
> > to choose what attribute set it carries.
> >
> > That said, most of the ext_ack attributes refer to an input attribute by
> > specifying the offset within the request. The notification recipient
> > will not be able to resolve those in any meaningful way. So since only
> > the string message will be of interest I reckon adding a full nest is
> > an unnecessary complication?
>
> Thanks for the explanation. I will try add the TCA_NTF_WARN_MSG to TCA
> space.
>
> Hangbin