From: Jiri Pirko <jiri@resnulli.us>
To: Eric Dumazet <edumazet@google.com>
Cc: Ido Schimmel <idosch@idosch.org>,
netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, bigeasy@linutronix.de, imagedong@tencent.com,
kuniyu@amazon.com, petrm@nvidia.com
Subject: Re: [patch net-next v2 3/3] net: devlink: add WARN_ON to check return value of unregister_netdevice_notifier_net() call
Date: Thu, 10 Nov 2022 08:53:09 +0100 [thread overview]
Message-ID: <Y2yt5SDkCPTeAoez@nanopsycho> (raw)
In-Reply-To: <CANn89iJgTLe0EJ61xYji6W-VzQAGtoXpZJAxgKe-nE9ESw=p7w@mail.gmail.com>
Wed, Nov 09, 2022 at 05:26:10PM CET, edumazet@google.com wrote:
>On Wed, Nov 9, 2022 at 3:49 AM Ido Schimmel <idosch@idosch.org> wrote:
>>
>> On Tue, Nov 08, 2022 at 02:22:08PM +0100, Jiri Pirko wrote:
>> > From: Jiri Pirko <jiri@nvidia.com>
>> >
>> > As the return value is not 0 only in case there is no such notifier
>> > block registered, add a WARN_ON() to yell about it.
>> >
>> > Suggested-by: Ido Schimmel <idosch@idosch.org>
>> > Signed-off-by: Jiri Pirko <jiri@nvidia.com>
>>
>> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
>
>Please consider WARN_ON_ONCE(), or DEBUG_NET_WARN_ON_ONCE()
Well, in this case, I think that plain WARN_ON is fine as this happens
only during driver cleanup which is not expected to happen very often
(or not at all) in real world scenarios.
next prev parent reply other threads:[~2022-11-10 7:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 13:22 [patch net-next v2 0/3] net: devlink: move netdev notifier block to dest namespace during reload Jiri Pirko
2022-11-08 13:22 ` [patch net-next v2 1/3] net: introduce a helper to move notifier block to different namespace Jiri Pirko
2022-11-09 11:56 ` Ido Schimmel
2022-11-08 13:22 ` [patch net-next v2 2/3] net: devlink: move netdev notifier block to dest namespace during reload Jiri Pirko
2022-11-08 13:22 ` [patch net-next v2 3/3] net: devlink: add WARN_ON to check return value of unregister_netdevice_notifier_net() call Jiri Pirko
2022-11-09 11:49 ` Ido Schimmel
2022-11-09 16:26 ` Eric Dumazet
2022-11-09 21:45 ` Jakub Kicinski
2022-11-10 7:54 ` Jiri Pirko
2022-11-10 17:21 ` Eric Dumazet
2022-11-10 18:04 ` Ido Schimmel
2022-11-10 18:07 ` Eric Dumazet
2022-11-10 7:53 ` Jiri Pirko [this message]
2022-11-10 0:20 ` [patch net-next v2 0/3] net: devlink: move netdev notifier block to dest namespace during reload patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2yt5SDkCPTeAoez@nanopsycho \
--to=jiri@resnulli.us \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@idosch.org \
--cc=imagedong@tencent.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).