From: Leon Romanovsky <leon@kernel.org>
To: Zhengchao Shao <shaozhengchao@huawei.com>
Cc: netdev@vger.kernel.org, dchickles@marvell.com,
sburla@marvell.com, fmanlunas@marvell.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
richardcochran@gmail.com, rvatsavayi@caviumnetworks.com,
gregkh@linuxfoundation.org, tseewald@gmail.com,
weiyongjun1@huawei.com, yuehaibing@huawei.com
Subject: Re: [PATCH net v2] net: liquidio: release resources when liquidio driver open failed
Date: Thu, 10 Nov 2022 12:38:58 +0200 [thread overview]
Message-ID: <Y2zUwncZudQKI3t1@unreal> (raw)
In-Reply-To: <20221110103037.133791-1-shaozhengchao@huawei.com>
On Thu, Nov 10, 2022 at 06:30:37PM +0800, Zhengchao Shao wrote:
> When liquidio driver open failed, it doesn't release resources. Compile
> tested only.
>
> Fixes: 5b07aee11227 ("liquidio: MSIX support for CN23XX")
> Fixes: dbc97bfd3918 ("net: liquidio: Add missing null pointer checks")
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
> v2: simplify "if" judgment statements
> ---
> .../net/ethernet/cavium/liquidio/lio_main.c | 34 ++++++++++++++-----
> 1 file changed, 26 insertions(+), 8 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2022-11-10 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 10:30 [PATCH net v2] net: liquidio: release resources when liquidio driver open failed Zhengchao Shao
2022-11-10 10:38 ` Leon Romanovsky [this message]
2022-11-14 10:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2zUwncZudQKI3t1@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=dchickles@marvell.com \
--cc=edumazet@google.com \
--cc=fmanlunas@marvell.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rvatsavayi@caviumnetworks.com \
--cc=sburla@marvell.com \
--cc=shaozhengchao@huawei.com \
--cc=tseewald@gmail.com \
--cc=weiyongjun1@huawei.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).