From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15ABBC4332F for ; Thu, 10 Nov 2022 10:39:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230265AbiKJKjx (ORCPT ); Thu, 10 Nov 2022 05:39:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230264AbiKJKjk (ORCPT ); Thu, 10 Nov 2022 05:39:40 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEB896A69F for ; Thu, 10 Nov 2022 02:39:15 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CE6D061229 for ; Thu, 10 Nov 2022 10:39:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD7C0C433D6; Thu, 10 Nov 2022 10:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668076743; bh=UdrAFpqAUGJu5JwZaMfMz+ZSHELxuegs3lgWKN72OdM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Rwk3mWyA1JYleaiahh6tbYkxwUfv/k3sctqJL2gjzyrAeSb0Ek5SBHVhEJzrx0cmG gZNybPsT7+yxDXhQGEuVwLfq9LW+oHa452RqR7AlJHY+UJKl8Jj5sJ82CKMiaCYFM4 F9mqDb9wge8J+saLrlQbKfAy1l2p7/ac3iTWi8N4s+acZ59kkw3NJukcRe3R6moyvH PgXSE6dn6wDnb+E1dYwAQAUxXzjPt8dXzdPvzT+DdESfufFH+lSAcW6tXaEcN3znGT JyTCCEmCDoc56kvVxC7fPptYcI05sNOpq9+9PoEfBlAi1UP/4YC4QpTKUWRi2XbpMY ZiSTHUw7zoxZQ== Date: Thu, 10 Nov 2022 12:38:58 +0200 From: Leon Romanovsky To: Zhengchao Shao Cc: netdev@vger.kernel.org, dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com, rvatsavayi@caviumnetworks.com, gregkh@linuxfoundation.org, tseewald@gmail.com, weiyongjun1@huawei.com, yuehaibing@huawei.com Subject: Re: [PATCH net v2] net: liquidio: release resources when liquidio driver open failed Message-ID: References: <20221110103037.133791-1-shaozhengchao@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221110103037.133791-1-shaozhengchao@huawei.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Nov 10, 2022 at 06:30:37PM +0800, Zhengchao Shao wrote: > When liquidio driver open failed, it doesn't release resources. Compile > tested only. > > Fixes: 5b07aee11227 ("liquidio: MSIX support for CN23XX") > Fixes: dbc97bfd3918 ("net: liquidio: Add missing null pointer checks") > Signed-off-by: Zhengchao Shao > --- > v2: simplify "if" judgment statements > --- > .../net/ethernet/cavium/liquidio/lio_main.c | 34 ++++++++++++++----- > 1 file changed, 26 insertions(+), 8 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky