From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86507C4332F for ; Tue, 22 Nov 2022 18:00:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233478AbiKVSAI (ORCPT ); Tue, 22 Nov 2022 13:00:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233207AbiKVSAH (ORCPT ); Tue, 22 Nov 2022 13:00:07 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91048C77F for ; Tue, 22 Nov 2022 10:00:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kdE+iTz7HdZsAUbIuguuCGxCwNValpGxi9IgpjV9eGI=; b=a1BplfK0145jUXUkm6G/Q+xtRt 8cDMfGG69PaNzFx5Tq3Vra29YGYP2l0HPvqJYmgad0fB5Rb9HJqipofFHJ7Xg7HGF/Np5l1p4GgAv hpC+p9x2Dy3l2w1jNkwN5dEV0r1nutgZJ9Q09pdy26h1BwcbO0mjfRoDsx6ut48kJ1kMIySUnZpDI bPc3HfHsAb01O0rfwjXnrinUKolLfaybBW0opChu+GaWFLs5fs/7f8m20PpV04fcQzNVI22WE42R0 xkUmqU/o7gmsKk8suhuopZ2aTjtTowqteBXLNvbUO12ORzp4OkdwCG2Uot8HlJd7fgy/LIN0YFNQY PHZnzD3Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35386) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oxXYs-0001ra-At; Tue, 22 Nov 2022 17:59:58 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oxXYk-0003Un-Qe; Tue, 22 Nov 2022 17:59:50 +0000 Date: Tue, 22 Nov 2022 17:59:50 +0000 From: "Russell King (Oracle)" To: Sean Anderson Cc: Vladimir Oltean , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heiner Kallweit , Andrew Lunn , Florian Fainelli , UNGLinuxDriver@microchip.com, bcm-kernel-feedback-list@broadcom.com, Madalin Bucur , Camelia Groza , Claudiu Manoil , Ioana Ciornei , Maxim Kochetkov , Antoine Tenart , Michael Walle , Raag Jadav , Siddharth Vadapalli , Ong Boon Leong , Colin Foster , Marek Behun Subject: Re: [PATCH v4 net-next 0/8] Let phylink manage in-band AN for the PHY Message-ID: References: <20221118000124.2754581-1-vladimir.oltean@nxp.com> <20221121194444.ran2bec6fhfk72lt@skbuf> <4bf812ec-f59b-6f64-b1e0-0feb54138bad@seco.com> <20221122001700.hilrumuzc5ulkafi@skbuf> <522f823f-70d2-d595-1f2b-1ca447c6f288@seco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <522f823f-70d2-d595-1f2b-1ca447c6f288@seco.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Nov 22, 2022 at 11:10:03AM -0500, Sean Anderson wrote: > So maybe we should do (PHY_AN_INBAND_ON | PHY_AN_INBAND_OFF) in that > case. That said, RGMII in-band is not supported by phylink (yet). I think people use it - why do you think it isn't supportable? Why would it need to be any different from something like SGMII? One can implement a "phylink_pcs" that responds appropriately when in RGMII mode (which I believe is what others have done.) Note that Marvell net drivers always register a PCS no matter what interface mode is being used - I believe the hardware has the ability to read the RGMII in-band and in that case it's just the same registers that one has to read to get the status as SGMII. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!