From: Leon Romanovsky <leon@kernel.org>
To: Suman Ghosh <sumang@marvell.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, sgoutham@marvell.com, sbhatta@marvell.com,
jerinj@marvell.com, gakula@marvell.com, hkelam@marvell.com,
lcherian@marvell.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [net PATCH] octeontx2-pf: Fix pfc_alloc_status array overflow
Date: Wed, 23 Nov 2022 09:57:37 +0200 [thread overview]
Message-ID: <Y33ScUx5t7f921uh@unreal> (raw)
In-Reply-To: <20221123051010.2725917-1-sumang@marvell.com>
On Wed, Nov 23, 2022 at 10:40:10AM +0530, Suman Ghosh wrote:
> This patch addresses pfc_alloc_status array overflow occurring for
> send queue index value greater than PFC priority. This is causing
> mbox errors as otx2_get_smq_idx returing invalid smq value.
Maybe this change is correct one, but commit message is missing an
explanation why internal function can receive "illegal" index and
why it is safe to continue.
>
> Fixes: 99c969a83d82 ("octeontx2-pf: Add egress PFC support")
>
No blank line here.
> Signed-off-by: Suman Ghosh <sumang@marvell.com>
> ---
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> index 282db6fe3b08..67aa02bb2b85 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> @@ -884,7 +884,7 @@ static inline void otx2_dma_unmap_page(struct otx2_nic *pfvf,
> static inline u16 otx2_get_smq_idx(struct otx2_nic *pfvf, u16 qidx)
> {
> #ifdef CONFIG_DCB
> - if (pfvf->pfc_alloc_status[qidx])
> + if (qidx < NIX_PF_PFC_PRIO_MAX && pfvf->pfc_alloc_status[qidx])
> return pfvf->pfc_schq_list[NIX_TXSCH_LVL_SMQ][qidx];
> #endif
>
> --
> 2.25.1
>
prev parent reply other threads:[~2022-11-23 7:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 5:10 [net PATCH] octeontx2-pf: Fix pfc_alloc_status array overflow Suman Ghosh
2022-11-23 7:57 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y33ScUx5t7f921uh@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).