* [net PATCH] octeontx2-pf: Fix pfc_alloc_status array overflow
@ 2022-11-23 5:10 Suman Ghosh
2022-11-23 7:57 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Suman Ghosh @ 2022-11-23 5:10 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, sgoutham, sbhatta, jerinj, gakula,
hkelam, lcherian, netdev, linux-kernel
Cc: Suman Ghosh
This patch addresses pfc_alloc_status array overflow occurring for
send queue index value greater than PFC priority. This is causing
mbox errors as otx2_get_smq_idx returing invalid smq value.
Fixes: 99c969a83d82 ("octeontx2-pf: Add egress PFC support")
Signed-off-by: Suman Ghosh <sumang@marvell.com>
---
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
index 282db6fe3b08..67aa02bb2b85 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
@@ -884,7 +884,7 @@ static inline void otx2_dma_unmap_page(struct otx2_nic *pfvf,
static inline u16 otx2_get_smq_idx(struct otx2_nic *pfvf, u16 qidx)
{
#ifdef CONFIG_DCB
- if (pfvf->pfc_alloc_status[qidx])
+ if (qidx < NIX_PF_PFC_PRIO_MAX && pfvf->pfc_alloc_status[qidx])
return pfvf->pfc_schq_list[NIX_TXSCH_LVL_SMQ][qidx];
#endif
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [net PATCH] octeontx2-pf: Fix pfc_alloc_status array overflow
2022-11-23 5:10 [net PATCH] octeontx2-pf: Fix pfc_alloc_status array overflow Suman Ghosh
@ 2022-11-23 7:57 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2022-11-23 7:57 UTC (permalink / raw)
To: Suman Ghosh
Cc: davem, edumazet, kuba, pabeni, sgoutham, sbhatta, jerinj, gakula,
hkelam, lcherian, netdev, linux-kernel
On Wed, Nov 23, 2022 at 10:40:10AM +0530, Suman Ghosh wrote:
> This patch addresses pfc_alloc_status array overflow occurring for
> send queue index value greater than PFC priority. This is causing
> mbox errors as otx2_get_smq_idx returing invalid smq value.
Maybe this change is correct one, but commit message is missing an
explanation why internal function can receive "illegal" index and
why it is safe to continue.
>
> Fixes: 99c969a83d82 ("octeontx2-pf: Add egress PFC support")
>
No blank line here.
> Signed-off-by: Suman Ghosh <sumang@marvell.com>
> ---
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> index 282db6fe3b08..67aa02bb2b85 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> @@ -884,7 +884,7 @@ static inline void otx2_dma_unmap_page(struct otx2_nic *pfvf,
> static inline u16 otx2_get_smq_idx(struct otx2_nic *pfvf, u16 qidx)
> {
> #ifdef CONFIG_DCB
> - if (pfvf->pfc_alloc_status[qidx])
> + if (qidx < NIX_PF_PFC_PRIO_MAX && pfvf->pfc_alloc_status[qidx])
> return pfvf->pfc_schq_list[NIX_TXSCH_LVL_SMQ][qidx];
> #endif
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-23 7:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-23 5:10 [net PATCH] octeontx2-pf: Fix pfc_alloc_status array overflow Suman Ghosh
2022-11-23 7:57 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).