From: Bobby Eshleman <bobbyeshleman@gmail.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Bobby Eshleman <bobby.eshleman@bytedance.com>,
Cong Wang <cong.wang@bytedance.com>,
Krasnov Arseniy <oxffffaa@gmail.com>,
Jiang Wang <jiang.wang@bytedance.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Eric Dumazet <edumazet@google.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
kvm@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v6] virtio/vsock: replace virtio_vsock_pkt with sk_buff
Date: Wed, 23 Nov 2022 12:31:28 +0000 [thread overview]
Message-ID: <Y34SoH1nFTXXLWbK@bullseye> (raw)
In-Reply-To: <20221213154304.rjrwzbv6jywkrpxq@sgarzare-redhat>
On Tue, Dec 13, 2022 at 04:43:04PM +0100, Stefano Garzarella wrote:
> On Tue, Dec 13, 2022 at 10:06:23AM -0500, Michael S. Tsirkin wrote:
> > On Tue, Dec 13, 2022 at 11:22:32AM +0100, Stefano Garzarella wrote:
> > > > + if (len <= GOOD_COPY_LEN && !skb_queue_empty_lockless(&vvs->rx_queue)) {
> > >
> > > Same here.
> > >
> > > If there are no major changes to be made, I think the next version is the
> > > final ones, though we are now in the merge window, so net-next is closed
> > > [1], only RFCs can be sent [2].
> > >
> > > I suggest you wait until the merge window is over (two weeks usually) to
> > > send the next version.
> >
> > Nah, you never know, could be more comments. And depending on the timing
> > I might be able to merge it.
>
> Right, in the end these changes are only to virtio-vsock transport, so they
> can go smoothly even with your tree.
>
> @Bobby, so if you can fix the remaining small things, we can try to merge it
> :-)
>
> Thanks,
> Stefano
Sure thing. I'll change / send now.
Best,
Bobby
prev parent reply other threads:[~2022-12-13 18:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 7:25 [PATCH net-next v6] virtio/vsock: replace virtio_vsock_pkt with sk_buff Bobby Eshleman
2022-12-13 10:22 ` Stefano Garzarella
2022-12-13 15:06 ` Michael S. Tsirkin
2022-12-13 15:43 ` Stefano Garzarella
2022-11-23 12:31 ` Bobby Eshleman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y34SoH1nFTXXLWbK@bullseye \
--to=bobbyeshleman@gmail.com \
--cc=bobby.eshleman@bytedance.com \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiang.wang@bytedance.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oxffffaa@gmail.com \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).