From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D2D1C4332F for ; Wed, 23 Nov 2022 13:31:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238236AbiKWNbS (ORCPT ); Wed, 23 Nov 2022 08:31:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237780AbiKWNat (ORCPT ); Wed, 23 Nov 2022 08:30:49 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8154F8C7AE for ; Wed, 23 Nov 2022 05:11:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XATNKwsK7P4099QjfNthxYrziF00WZy9uRXZWFnsFQs=; b=Yi1iGMR1XxH3VLSM3xpar6r9gp 1Ce68AcgQhR3F3TxN5yDj80lLJLjDEVGz66G7+9DHWllYSIdBRULS9TqH2ivsvOoZuyy5N5gb2uQ4 Un9yh3q3xA394bd40TwpPWriQaTC4lGoxFLXBv/Dt31P2TnhHjLfdrtbd/WKF5DvG5aMcaB1rEDxt a4YjfakEAygdDEje8G1IEEqhxRPRIgYCoZFpZqomQstDZB6q02h+8yBJ5cWxsBZ6mclr3uGGWb//m Vle/pCiOujHd4DyC8XgLeUKjrMhA5N3KVgmiulperAO9538K+IEsILfqBo1Dk4MV8g+O9WPqL0CuW 6KexbGew==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35406) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oxpXH-0002uA-6F; Wed, 23 Nov 2022 13:11:31 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oxpX9-0004K8-Ui; Wed, 23 Nov 2022 13:11:23 +0000 Date: Wed, 23 Nov 2022 13:11:23 +0000 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heiner Kallweit , Andrew Lunn , Florian Fainelli , UNGLinuxDriver@microchip.com, bcm-kernel-feedback-list@broadcom.com, Madalin Bucur , Camelia Groza , Claudiu Manoil , Ioana Ciornei , Maxim Kochetkov , Sean Anderson , Antoine Tenart , Michael Walle , Raag Jadav , Siddharth Vadapalli , Ong Boon Leong , Colin Foster , Marek Behun Subject: Re: [PATCH v4 net-next 3/8] net: phy: bcm84881: move the in-band capability check where it belongs Message-ID: References: <20221118000124.2754581-1-vladimir.oltean@nxp.com> <20221118000124.2754581-4-vladimir.oltean@nxp.com> <20221122121122.klqkw4onjxabyi22@skbuf> <20221122175603.soux2q2cxs2wfsun@skbuf> <20221122193618.p57qrvhymeegu7cs@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Nov 23, 2022 at 12:08:11PM +0000, Russell King (Oracle) wrote: > On Tue, Nov 22, 2022 at 09:36:59PM +0200, Vladimir Oltean wrote: > > I think we're in agreement, but please let's wait until tomorrow, I need > > to take a break for today. > > I think we do have a sort of agreement... but lets give this a go. The > following should be sufficient for copper SFP modules using the 88E1111 > PHY. However, I haven't build-tested this patch yet. > > Reading through the documentation has brought up some worms in this > area. :( > > It may be worth printing the fiber page BMCR and extsr at various > strategic points in this driver and reporting back if things don't > seem to be working right for your modules. In the mean time, I'll try > to see how the modules in the Honeycomb appear to be setup at power-up > and after the driver has configured the PHY... assuming I left both > MicroUSBs connected and the board has a network connection via the > main ethernet jack. Unfortunately, I don't have a SFP with an 88e1111 plugged in, only the bcm84881, so I can't test my patch remotely. However, it builds fine when the appropriate TIMEOUT definition is added. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!