From: Jason Gunthorpe <jgg@ziepe.ca>
To: Guoqing Jiang <guoqing.jiang@linux.dev>,
Bernard Metzler <bmt@zurich.ibm.com>
Cc: wangyufen <wangyufen@huawei.com>,
Dmitry Vyukov <dvyukov@google.com>,
syzbot <syzbot+5e70d01ee8985ae62a3b@syzkaller.appspotmail.com>,
Leon Romanovsky <leon@kernel.org>,
chenzhongjin@huawei.com,
RDMA mailing list <linux-rdma@vger.kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
syzkaller-bugs@googlegroups.com,
Zhu Yanjun <zyjzyj2000@gmail.com>,
Bob Pearson <rpearsonhpe@gmail.com>
Subject: Re: [syzbot] unregister_netdevice: waiting for DEV to become free (7)
Date: Wed, 23 Nov 2022 20:22:35 -0400 [thread overview]
Message-ID: <Y365S5s5qRQvm8m0@ziepe.ca> (raw)
In-Reply-To: <2f54056f-0acf-e088-c6cc-9ffce77bbe24@linux.dev>
On Wed, Nov 23, 2022 at 05:45:53PM +0800, Guoqing Jiang wrote:
> But it is the caller's responsibility to destroy it since commit
> dd37d2f59eb8.
>
> > The causes are as follows:
> >
> > rdma_listen()
> > rdma_bind_addr()
> > cma_acquire_dev_by_src_ip()
> > cma_attach_to_dev()
> > _cma_attach_to_dev()
> > cma_dev_get()
>
> Thanks for the analysis.
>
> And for the two callers of cma_listen_on_dev, looks they have
> different behaviors with regard to handling failure.
Yes, the CM is not the problem, and that print from it is unrelated
I patched in netdevice_tracker and get this:
[ 237.475070][ T7541] unregister_netdevice: waiting for vlan0 to become free. Usage count = 2
[ 237.477311][ T7541] leaked reference.
[ 237.478378][ T7541] ib_device_set_netdev+0x266/0x730
[ 237.479848][ T7541] siw_newlink+0x4e0/0xfd0
[ 237.481100][ T7541] nldev_newlink+0x35c/0x5c0
[ 237.482121][ T7541] rdma_nl_rcv_msg+0x36d/0x690
[ 237.483312][ T7541] rdma_nl_rcv+0x2ee/0x430
[ 237.484483][ T7541] netlink_unicast+0x543/0x7f0
[ 237.485746][ T7541] netlink_sendmsg+0x918/0xe20
[ 237.486866][ T7541] sock_sendmsg+0xcf/0x120
[ 237.488006][ T7541] ____sys_sendmsg+0x70d/0x8b0
[ 237.489294][ T7541] ___sys_sendmsg+0x11d/0x1b0
[ 237.490404][ T7541] __sys_sendmsg+0xfa/0x1d0
[ 237.491451][ T7541] do_syscall_64+0x35/0xb0
[ 237.492566][ T7541] entry_SYSCALL_64_after_hwframe+0x63/0xcd
Which seems to confirm my original prediction, except this is siw not
rxe..
Maybe rxe was the wrong guess, or maybe it is troubled too in other
reports?
Jason
next prev parent reply other threads:[~2022-11-24 0:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 11:39 [syzbot] unregister_netdevice: waiting for DEV to become free (7) syzbot
2022-11-18 13:28 ` Dmitry Vyukov
2022-11-22 2:13 ` Jason Gunthorpe
2022-11-22 3:28 ` wangyufen
2022-11-23 9:45 ` Guoqing Jiang
2022-11-24 0:22 ` Jason Gunthorpe [this message]
2022-11-24 1:42 ` wangyufen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y365S5s5qRQvm8m0@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bmt@zurich.ibm.com \
--cc=chenzhongjin@huawei.com \
--cc=dvyukov@google.com \
--cc=guoqing.jiang@linux.dev \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=syzbot+5e70d01ee8985ae62a3b@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=wangyufen@huawei.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).