Re: [PATCH net] bnxt_en: Remove debugfs when pci_register_driver failed

[Leon Romanovsky <leon@kernel.org>]

On Fri, Nov 11, 2022 at 03:04:33PM +0800, Gaosheng Cui wrote:
> When pci_register_driver failed, we need to remove debugfs,
> which will caused a resource leak, fix it.
> 
> Resource leak logs as follows:
> [   52.184456] debugfs: Directory 'bnxt_en' with parent '/' already present!
> 
> Fixes: cabfb09d87bd ("bnxt_en: add debugfs support for DIM")
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 743504a27b71..0fe164b42c5d 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -14059,8 +14059,16 @@ static struct pci_driver bnxt_pci_driver = {
>  
>  static int __init bnxt_init(void)
>  {
> +	int err;
> +
>  	bnxt_debug_init();
> -	return pci_register_driver(&bnxt_pci_driver);
> +	err = pci_register_driver(&bnxt_pci_driver);
> +	if (err) {
> +		bnxt_debug_exit();
> +		return err;
> +	}
> +
> +	return 0;
>  }
>  

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>