From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C226EC433FE for ; Sun, 13 Nov 2022 08:02:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234627AbiKMICo (ORCPT ); Sun, 13 Nov 2022 03:02:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233069AbiKMICm (ORCPT ); Sun, 13 Nov 2022 03:02:42 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C134813E97 for ; Sun, 13 Nov 2022 00:02:41 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 431F760B1A for ; Sun, 13 Nov 2022 08:02:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA59AC433D6; Sun, 13 Nov 2022 08:02:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668326559; bh=ytFdfs058L5ijRmzc+7As48eGT1KENit1zTKFoAbfyU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PowDYh+EjTm2Fng74z4Pa98MdDIlatbTMyY2p8y/v7SC+zhaRpQSFNXpGn319kGOa PNisEP9E5U30nYtV0ahdrnvgUMxltGFvLUIHnHU6vQUl2FLQapX0xGvDQZvs0IdRdU xGSaG4yShrjhHmxKm0Dg3rX4zfVhiz9JnDm/ijr8P4QEmnQTnxuJYCsaCEmMXgBOTa eBM2Cxf5toVnCQA1yQzHluRMqxrKMZTOVSNCCzH5FG9PlXTt9JumY2kjVlRHb1SjWK mYS8T2wILjH35rMPVg9OuBxTLEpfrWZnmErYeJ3KXM3Z2yOLCGWc6n+SoBirrJEIrS T8fVRrQZit8+g== Date: Sun, 13 Nov 2022 10:02:34 +0200 From: Leon Romanovsky To: Gaosheng Cui Cc: michael.chan@broadcom.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, gospo@broadcom.com, netdev@vger.kernel.org Subject: Re: [PATCH net] bnxt_en: Remove debugfs when pci_register_driver failed Message-ID: References: <20221111070433.3498215-1-cuigaosheng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221111070433.3498215-1-cuigaosheng1@huawei.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Nov 11, 2022 at 03:04:33PM +0800, Gaosheng Cui wrote: > When pci_register_driver failed, we need to remove debugfs, > which will caused a resource leak, fix it. > > Resource leak logs as follows: > [ 52.184456] debugfs: Directory 'bnxt_en' with parent '/' already present! > > Fixes: cabfb09d87bd ("bnxt_en: add debugfs support for DIM") > Signed-off-by: Gaosheng Cui > --- > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c > index 743504a27b71..0fe164b42c5d 100644 > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c > @@ -14059,8 +14059,16 @@ static struct pci_driver bnxt_pci_driver = { > > static int __init bnxt_init(void) > { > + int err; > + > bnxt_debug_init(); > - return pci_register_driver(&bnxt_pci_driver); > + err = pci_register_driver(&bnxt_pci_driver); > + if (err) { > + bnxt_debug_exit(); > + return err; > + } > + > + return 0; > } > Thanks, Reviewed-by: Leon Romanovsky