[PATCH net] bnxt_en: Remove debugfs when pci_register_driver failed

[PATCH net] bnxt_en: Remove debugfs when pci_register_driver failed

[Gaosheng Cui]

When pci_register_driver failed, we need to remove debugfs,
which will caused a resource leak, fix it.

Resource leak logs as follows:
[   52.184456] debugfs: Directory 'bnxt_en' with parent '/' already present!

Fixes: cabfb09d87bd ("bnxt_en: add debugfs support for DIM")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 743504a27b71..0fe164b42c5d 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -14059,8 +14059,16 @@ static struct pci_driver bnxt_pci_driver = {
 
 static int __init bnxt_init(void)
 {
+	int err;
+
 	bnxt_debug_init();
-	return pci_register_driver(&bnxt_pci_driver);
+	err = pci_register_driver(&bnxt_pci_driver);
+	if (err) {
+		bnxt_debug_exit();
+		return err;
+	}
+
+	return 0;
 }
 
 static void __exit bnxt_exit(void)
-- 
2.25.1

Re: [PATCH net] bnxt_en: Remove debugfs when pci_register_driver failed

[Leon Romanovsky]

On Fri, Nov 11, 2022 at 03:04:33PM +0800, Gaosheng Cui wrote:
> When pci_register_driver failed, we need to remove debugfs,
> which will caused a resource leak, fix it.
> 
> Resource leak logs as follows:
> [   52.184456] debugfs: Directory 'bnxt_en' with parent '/' already present!
> 
> Fixes: cabfb09d87bd ("bnxt_en: add debugfs support for DIM")
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 743504a27b71..0fe164b42c5d 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -14059,8 +14059,16 @@ static struct pci_driver bnxt_pci_driver = {
>  
>  static int __init bnxt_init(void)
>  {
> +	int err;
> +
>  	bnxt_debug_init();
> -	return pci_register_driver(&bnxt_pci_driver);
> +	err = pci_register_driver(&bnxt_pci_driver);
> +	if (err) {
> +		bnxt_debug_exit();
> +		return err;
> +	}
> +
> +	return 0;
>  }
>  

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

Re: [PATCH net] bnxt_en: Remove debugfs when pci_register_driver failed

[Michael Chan]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

On Thu, Nov 10, 2022 at 11:04 PM Gaosheng Cui <cuigaosheng1@huawei.com> wrote:
>
> When pci_register_driver failed, we need to remove debugfs,
> which will caused a resource leak, fix it.
>
> Resource leak logs as follows:
> [   52.184456] debugfs: Directory 'bnxt_en' with parent '/' already present!
>
> Fixes: cabfb09d87bd ("bnxt_en: add debugfs support for DIM")
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>

Thanks.
Reviewed-by: Michael Chan <michael.chan@broadcom.com>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

Re: [PATCH net] bnxt_en: Remove debugfs when pci_register_driver failed

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 11 Nov 2022 15:04:33 +0800 you wrote:
> When pci_register_driver failed, we need to remove debugfs,
> which will caused a resource leak, fix it.
> 
> Resource leak logs as follows:
> [   52.184456] debugfs: Directory 'bnxt_en' with parent '/' already present!
> 
> Fixes: cabfb09d87bd ("bnxt_en: add debugfs support for DIM")
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> 
> [...]

Here is the summary with links:
  - [net] bnxt_en: Remove debugfs when pci_register_driver failed
    https://git.kernel.org/netdev/net/c/991aef4ee4f6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html