From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id C950FC4332F
	for <netdev@archiver.kernel.org>; Sun, 13 Nov 2022 19:04:10 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235405AbiKMTEJ (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sun, 13 Nov 2022 14:04:09 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43198 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232799AbiKMTEI (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 13 Nov 2022 14:04:08 -0500
Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6453FC744;
        Sun, 13 Nov 2022 11:04:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:
        Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
        Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;
        bh=xdAqZSVxm7Y0UeN6aDvnqxEcWxjFN6zP4RUdjTHboHw=; b=wdFlr+tVkBzJGfMDe+ohZSJYCR
        7DGvlXDW43xCE/XPaCiFNbaeQ37R4sU1YoWdT8gWpTgBt5a5WeG7DYrHAO1Gf9E9Wvn3JIJ2B1ETE
        dXgvmNku+hAnZV2dQwosLoK9tzmuoQctFInQ3RhlGHL3unlbz/dR/36fnQY5sOrBMfL4=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1ouIGx-002G7D-If; Sun, 13 Nov 2022 20:04:03 +0100
Date:   Sun, 13 Nov 2022 20:04:03 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Hariprasad Kelam <hkelam@marvell.com>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "edumazet@google.com" <edumazet@google.com>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
Subject: Re: [net-next PATCH 0/9] CN10KB MAC block support
Message-ID: <Y3E/o10wIZPMxPWa@lunn.ch>
References: <20221112043141.13291-1-hkelam@marvell.com>
 <20221111211235.2e8f03c0@kernel.org>
 <Y2/nhhi2jGUSk7L/@lunn.ch>
 <PH0PR18MB4474E9CFE1E1FBF8EAF71817DE029@PH0PR18MB4474.namprd18.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <PH0PR18MB4474E9CFE1E1FBF8EAF71817DE029@PH0PR18MB4474.namprd18.prod.outlook.com>
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> For  "Dropped packets by DMAC filters" did not find any equivalent APIs, so will keep it as is.

Nope. Propose a generic netlink API, probably as an extension to
ethtool, which other vendors can use as well.

This is exactly Jakub and my point. Is your hardware so special it
does things which no other vendor does? Is the concept of DMAC filters
dropping packets unique to your hardware? Is this feature so obscure
that no other vendor will ever implement it? And if it is that
obscure, is any user actually going to use it?

	Andrew