* [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes
@ 2022-11-13 20:33 Thomas Gleixner
2022-11-13 20:34 ` [patch 06/10] net: dpaa2: Remove " Thomas Gleixner
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Thomas Gleixner @ 2022-11-13 20:33 UTC (permalink / raw)
To: LKML
Cc: Marc Zyngier, Lee Jones, Damien Le Moal, linux-ide, James Smart,
Dick Kennedy, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, Stuart Yoder, Laurentiu Tudor, Fenghua Yu, Dave Jiang,
Vinod Koul, dmaengine, Ioana Ciornei, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, Simon Horman,
oss-drivers, Roy Pledge, Diana Craciun, Alex Williamson,
Cornelia Huck, kvm, Joerg Roedel, Will Deacon, Robin Murphy,
iommu
While working on per device MSI domains I noticed that quite some files
include linux/msi.h just because.
The top level comment in the header file clearly says:
Regular device drivers have no business with any of these functions....
and actually none of the drivers needs anything from msi.h.
The series is not depending on anything so the individual patches can be
picked up by the relevant maintainers. I'll mop up the leftovers close to
the merge window.
Thanks,
tglx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [patch 06/10] net: dpaa2: Remove linux/msi.h includes
2022-11-13 20:33 [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes Thomas Gleixner
@ 2022-11-13 20:34 ` Thomas Gleixner
2022-11-13 20:34 ` [patch 07/10] net: nfp: " Thomas Gleixner
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Thomas Gleixner @ 2022-11-13 20:34 UTC (permalink / raw)
To: LKML
Cc: Marc Zyngier, Ioana Ciornei, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev
Nothing in these file needs anything from linux/msi.h
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 1 -
drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c | 1 -
drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c | 1 -
3 files changed, 3 deletions(-)
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
@@ -8,7 +8,6 @@
#include <linux/etherdevice.h>
#include <linux/of_net.h>
#include <linux/interrupt.h>
-#include <linux/msi.h>
#include <linux/kthread.h>
#include <linux/iommu.h>
#include <linux/fsl/mc.h>
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c
@@ -8,7 +8,6 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_address.h>
-#include <linux/msi.h>
#include <linux/fsl/mc.h>
#include "dpaa2-ptp.h"
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c
@@ -10,7 +10,6 @@
#include <linux/module.h>
#include <linux/interrupt.h>
-#include <linux/msi.h>
#include <linux/kthread.h>
#include <linux/workqueue.h>
#include <linux/iommu.h>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [patch 07/10] net: nfp: Remove linux/msi.h includes
2022-11-13 20:33 [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes Thomas Gleixner
2022-11-13 20:34 ` [patch 06/10] net: dpaa2: Remove " Thomas Gleixner
@ 2022-11-13 20:34 ` Thomas Gleixner
2022-11-14 10:46 ` Simon Horman
2022-11-15 3:00 ` [patch 00/10] genirq/msi: Treewide cleanup of pointless " patchwork-bot+netdevbpf
2022-11-26 3:27 ` Martin K. Petersen
3 siblings, 1 reply; 6+ messages in thread
From: Thomas Gleixner @ 2022-11-13 20:34 UTC (permalink / raw)
To: LKML
Cc: Marc Zyngier, Simon Horman, Jakub Kicinski, David S. Miller,
Eric Dumazet, Paolo Abeni, oss-drivers, netdev
Nothing in these files needs anything from linux/msi.h
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Simon Horman <simon.horman@corigine.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: oss-drivers@corigine.com
Cc: netdev@vger.kernel.org
---
drivers/net/ethernet/netronome/nfp/nfp_main.h | 1 -
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 1 -
drivers/net/ethernet/netronome/nfp/nfp_net_main.c | 1 -
3 files changed, 3 deletions(-)
--- a/drivers/net/ethernet/netronome/nfp/nfp_main.h
+++ b/drivers/net/ethernet/netronome/nfp/nfp_main.h
@@ -12,7 +12,6 @@
#include <linux/ethtool.h>
#include <linux/list.h>
#include <linux/types.h>
-#include <linux/msi.h>
#include <linux/pci.h>
#include <linux/workqueue.h>
#include <net/devlink.h>
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
@@ -27,7 +27,6 @@
#include <linux/page_ref.h>
#include <linux/pci.h>
#include <linux/pci_regs.h>
-#include <linux/msi.h>
#include <linux/ethtool.h>
#include <linux/log2.h>
#include <linux/if_vlan.h>
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_main.c
@@ -16,7 +16,6 @@
#include <linux/lockdep.h>
#include <linux/pci.h>
#include <linux/pci_regs.h>
-#include <linux/msi.h>
#include <linux/random.h>
#include <linux/rtnetlink.h>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 07/10] net: nfp: Remove linux/msi.h includes
2022-11-13 20:34 ` [patch 07/10] net: nfp: " Thomas Gleixner
@ 2022-11-14 10:46 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2022-11-14 10:46 UTC (permalink / raw)
To: Thomas Gleixner
Cc: LKML, Marc Zyngier, Jakub Kicinski, David S. Miller, Eric Dumazet,
Paolo Abeni, oss-drivers, netdev
On Sun, Nov 13, 2022 at 09:34:05PM +0100, Thomas Gleixner wrote:
> [Some people who received this message don't often get email from tglx@linutronix.de. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Nothing in these files needs anything from linux/msi.h
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Simon Horman <simon.horman@corigine.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: oss-drivers@corigine.com
> Cc: netdev@vger.kernel.org
Acked-by: Simon Horman <simon.horman@corigine.com>
> ---
> drivers/net/ethernet/netronome/nfp/nfp_main.h | 1 -
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 1 -
> drivers/net/ethernet/netronome/nfp/nfp_net_main.c | 1 -
> 3 files changed, 3 deletions(-)
>
> --- a/drivers/net/ethernet/netronome/nfp/nfp_main.h
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_main.h
> @@ -12,7 +12,6 @@
> #include <linux/ethtool.h>
> #include <linux/list.h>
> #include <linux/types.h>
> -#include <linux/msi.h>
> #include <linux/pci.h>
> #include <linux/workqueue.h>
> #include <net/devlink.h>
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> @@ -27,7 +27,6 @@
> #include <linux/page_ref.h>
> #include <linux/pci.h>
> #include <linux/pci_regs.h>
> -#include <linux/msi.h>
> #include <linux/ethtool.h>
> #include <linux/log2.h>
> #include <linux/if_vlan.h>
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_main.c
> @@ -16,7 +16,6 @@
> #include <linux/lockdep.h>
> #include <linux/pci.h>
> #include <linux/pci_regs.h>
> -#include <linux/msi.h>
> #include <linux/random.h>
> #include <linux/rtnetlink.h>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes
2022-11-13 20:33 [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes Thomas Gleixner
2022-11-13 20:34 ` [patch 06/10] net: dpaa2: Remove " Thomas Gleixner
2022-11-13 20:34 ` [patch 07/10] net: nfp: " Thomas Gleixner
@ 2022-11-15 3:00 ` patchwork-bot+netdevbpf
2022-11-26 3:27 ` Martin K. Petersen
3 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-15 3:00 UTC (permalink / raw)
To: Thomas Gleixner
Cc: linux-kernel, maz, lee, damien.lemoal, linux-ide, james.smart,
dick.kennedy, jejb, martin.petersen, linux-scsi, stuyoder,
laurentiu.tudor, fenghua.yu, dave.jiang, vkoul, dmaengine,
ioana.ciornei, davem, edumazet, kuba, pabeni, netdev,
simon.horman, oss-drivers, Roy.Pledge, diana.craciun,
alex.williamson, cohuck, kvm, joro, will, robin.murphy, iommu
Hello:
This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 13 Nov 2022 21:33:54 +0100 (CET) you wrote:
> While working on per device MSI domains I noticed that quite some files
> include linux/msi.h just because.
>
> The top level comment in the header file clearly says:
>
> Regular device drivers have no business with any of these functions....
>
> [...]
Here is the summary with links:
- [06/10] net: dpaa2: Remove linux/msi.h includes
https://git.kernel.org/netdev/net-next/c/515e5fb6a95e
- [07/10] net: nfp: Remove linux/msi.h includes
https://git.kernel.org/netdev/net-next/c/5fd66a0b3bb4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes
2022-11-13 20:33 [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes Thomas Gleixner
` (2 preceding siblings ...)
2022-11-15 3:00 ` [patch 00/10] genirq/msi: Treewide cleanup of pointless " patchwork-bot+netdevbpf
@ 2022-11-26 3:27 ` Martin K. Petersen
3 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2022-11-26 3:27 UTC (permalink / raw)
To: Thomas Gleixner, LKML
Cc: Martin K . Petersen, Fenghua Yu, oss-drivers, James Smart,
Cornelia Huck, dmaengine, Paolo Abeni, Will Deacon, Lee Jones,
Vinod Koul, Jakub Kicinski, Robin Murphy, Roy Pledge,
Damien Le Moal, Ioana Ciornei, iommu, Joerg Roedel,
Alex Williamson, netdev, kvm, James E.J. Bottomley, Marc Zyngier,
Diana Craciun, Simon Horman, Stuart Yoder, David S. Miller,
Dick Kennedy, linux-scsi, Dave Jiang, linux-ide, Eric Dumazet,
Laurentiu Tudor
On Sun, 13 Nov 2022 21:33:54 +0100 (CET), Thomas Gleixner wrote:
> While working on per device MSI domains I noticed that quite some files
> include linux/msi.h just because.
>
> The top level comment in the header file clearly says:
>
> Regular device drivers have no business with any of these functions....
>
> [...]
Applied to 6.2/scsi-queue, thanks!
[03/10] scsi: lpfc: Remove linux/msi.h include
https://git.kernel.org/mkp/scsi/c/cdd9344e00b4
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-26 3:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-13 20:33 [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes Thomas Gleixner
2022-11-13 20:34 ` [patch 06/10] net: dpaa2: Remove " Thomas Gleixner
2022-11-13 20:34 ` [patch 07/10] net: nfp: " Thomas Gleixner
2022-11-14 10:46 ` Simon Horman
2022-11-15 3:00 ` [patch 00/10] genirq/msi: Treewide cleanup of pointless " patchwork-bot+netdevbpf
2022-11-26 3:27 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).