From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E272CC4332F for ; Mon, 14 Nov 2022 17:12:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237311AbiKNRMC (ORCPT ); Mon, 14 Nov 2022 12:12:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237657AbiKNRL4 (ORCPT ); Mon, 14 Nov 2022 12:11:56 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4EA031EF7 for ; Mon, 14 Nov 2022 09:11:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lyf6xccXdatcijPwAUWt1NpAfeFk1lzqYgswZ+K8NIM=; b=SJII2BVaFMf12SVjsWPp6sVZRy wm1jdVwI6PXVEnUOLkwkaaxWsSZgSiEvBhiCWEIkbe1PUM9oUg4ZwZZ2Cz5n5J0vo7pmBRyyNMdrM LRPlHYY3zFrTojtj8WNwtqD+aLVrcjX0va38MTeRsysbiHJqiXrgPfXSuZgx/xazN63X9ZiuMMY5e HNHJvtSYFsgX5sFpdT3QGHDL7bIx37yyRN5fLn9Ahde78Yi036C1m4jXfUJJJ8SMOTUnTPkLeqIuA TBgDbudVtu6HftgLcHcg2ocyKbekV4RNBstMp7bI6FqYJgAjcj/zzXiwQizIagGa06Frv6QTAOuLe TvOTrXIg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35272) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ouczx-00019l-Sn; Mon, 14 Nov 2022 17:11:53 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1ouczx-0003yt-2j; Mon, 14 Nov 2022 17:11:53 +0000 Date: Mon, 14 Nov 2022 17:11:53 +0000 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: netdev@vger.kernel.org, Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Heiner Kallweit , Sean Anderson , Colin Foster , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH v2 net-next 4/4] net: dsa: remove phylink_validate() method Message-ID: References: <20221114170730.2189282-1-vladimir.oltean@nxp.com> <20221114170730.2189282-5-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221114170730.2189282-5-vladimir.oltean@nxp.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Nov 14, 2022 at 07:07:30PM +0200, Vladimir Oltean wrote: > As of now, no DSA driver uses a custom link mode validation procedure > anymore. So remove this DSA operation and let phylink determine what is > supported based on config->mac_capabilities (if provided by the driver). > Leave a comment why we left the code that we did, and that there is more > work to do. > > Signed-off-by: Vladimir Oltean Yay! Reviewed-by: Russell King (Oracle) Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!