From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
UNGLinuxDriver@microchip.com,
Heiner Kallweit <hkallweit1@gmail.com>,
Sean Anderson <sean.anderson@seco.com>,
Colin Foster <colin.foster@in-advantage.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH v2 net-next 2/4] net: dsa: felix: use phylink_generic_validate()
Date: Mon, 14 Nov 2022 17:09:46 +0000 [thread overview]
Message-ID: <Y3J2WojkiNzbOMY6@shell.armlinux.org.uk> (raw)
In-Reply-To: <20221114170730.2189282-3-vladimir.oltean@nxp.com>
On Mon, Nov 14, 2022 at 07:07:28PM +0200, Vladimir Oltean wrote:
> Drop the custom implementation of phylink_validate() in favor of the
> generic one, which requires config->mac_capabilities to be set.
>
> This was used up until now because of the possibility of being paired
> with Aquantia PHYs with support for rate matching. The phylink framework
> gained generic support for these, and knows to advertise all 10/100/1000
> lower speed link modes when our SERDES protocol is 2500base-x
> (fixed speed).
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
LGTM.
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-11-14 17:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 17:07 [PATCH v2 net-next 0/4] Remove phylink_validate() from Felix DSA driver Vladimir Oltean
2022-11-14 17:07 ` [PATCH v2 net-next 1/4] net: phy: aquantia: add AQR112 and AQR412 PHY IDs Vladimir Oltean
2022-11-14 17:07 ` [PATCH v2 net-next 2/4] net: dsa: felix: use phylink_generic_validate() Vladimir Oltean
2022-11-14 17:09 ` Russell King (Oracle) [this message]
2022-11-14 17:07 ` [PATCH v2 net-next 3/4] net: mscc: ocelot: drop workaround for forcing RX flow control Vladimir Oltean
2022-11-14 17:10 ` Russell King (Oracle)
2022-11-14 17:07 ` [PATCH v2 net-next 4/4] net: dsa: remove phylink_validate() method Vladimir Oltean
2022-11-14 17:11 ` Russell King (Oracle)
2022-11-16 5:00 ` [PATCH v2 net-next 0/4] Remove phylink_validate() from Felix DSA driver patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3J2WojkiNzbOMY6@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sean.anderson@seco.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).