From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06077C4332F for ; Mon, 14 Nov 2022 17:09:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238112AbiKNRJ4 (ORCPT ); Mon, 14 Nov 2022 12:09:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238094AbiKNRJy (ORCPT ); Mon, 14 Nov 2022 12:09:54 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C77B1B1F1 for ; Mon, 14 Nov 2022 09:09:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lfkP0HdkPkQvBtRrPiRbkjHURYLcSLHYJdSisiKXmZ8=; b=02r0v8mzOF7OVld/dtPGgY7lR0 Sql7/2JKijyHi4XMja/olmPWnD4vRXJn7zRZ/gXaZ4DLyaIv3zyCP/g8yO0csE+Jk7VpgzEUpfSXq DXXxHvk4mCfwsevM1azo6jH5X3gSzBJTsXdtG//6HFQB2G2ZIinT29kHL1kRqsnmCxaYh2FKiQSXR KE0Qc+SKMYbJIfwANSItQaIPXRJO27DypVSS1gWtQhI9wWsjAydTzoqXdNsjwCYsJguUg44VInDKx qjGFPsz0NnZ9IAe/R9DJ9WeoxMXTSClO0jQ/rjXR5qvSYEMcOqDQJ9q2Ot+aDDyArtAtqFo6dsd9U QeOd2QpQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35268) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oucxx-00018t-Uh; Mon, 14 Nov 2022 17:09:50 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oucxu-0003yf-Na; Mon, 14 Nov 2022 17:09:46 +0000 Date: Mon, 14 Nov 2022 17:09:46 +0000 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: netdev@vger.kernel.org, Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Heiner Kallweit , Sean Anderson , Colin Foster , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH v2 net-next 2/4] net: dsa: felix: use phylink_generic_validate() Message-ID: References: <20221114170730.2189282-1-vladimir.oltean@nxp.com> <20221114170730.2189282-3-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221114170730.2189282-3-vladimir.oltean@nxp.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Nov 14, 2022 at 07:07:28PM +0200, Vladimir Oltean wrote: > Drop the custom implementation of phylink_validate() in favor of the > generic one, which requires config->mac_capabilities to be set. > > This was used up until now because of the possibility of being paired > with Aquantia PHYs with support for rate matching. The phylink framework > gained generic support for these, and knows to advertise all 10/100/1000 > lower speed link modes when our SERDES protocol is 2500base-x > (fixed speed). > > Signed-off-by: Vladimir Oltean LGTM. Reviewed-by: Russell King (Oracle) Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!