netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 net-next 0/2] cleanup ocelot_stats exposure
@ 2022-11-11 20:49 Colin Foster
  2022-11-11 20:49 ` [PATCH v1 net-next 1/2] net: mscc: ocelot: remove redundant stats_layout pointers Colin Foster
  2022-11-11 20:49 ` [PATCH v1 net-next 2/2] net: mscc: ocelot: remove unnecessary exposure of stats structures Colin Foster
  0 siblings, 2 replies; 13+ messages in thread
From: Colin Foster @ 2022-11-11 20:49 UTC (permalink / raw)
  To: linux-kernel, netdev
  Cc: Paolo Abeni, Eric Dumazet, David S. Miller, Florian Fainelli,
	Andrew Lunn, Alexandre Belloni, Claudiu Manoil, Vladimir Oltean

The ocelot_stats structures became redundant across all users. Replace
this redundancy with a static const struct. After doing this, several
definitions inside include/soc/mscc/ocelot.h no longer needed to be
shared. Patch 2 removes them.

Checkpatch throws an error for a complicated macro not in parentheses. I
understand the reason for OCELOT_COMMON_STATS was to allow expansion, but
interestingly this patch set is essentially reverting the ability for
expansion. I'm keeping the macro in this set, but am open to remove it,
since it doesn't _actually_ provide any immediate benefits anymore.

Colin Foster (2):
  net: mscc: ocelot: remove redundant stats_layout pointers
  net: mscc: ocelot: remove unnecessary exposure of stats structures

 drivers/net/dsa/ocelot/felix.c             |   1 -
 drivers/net/dsa/ocelot/felix.h             |   1 -
 drivers/net/dsa/ocelot/felix_vsc9959.c     |   5 -
 drivers/net/dsa/ocelot/seville_vsc9953.c   |   5 -
 drivers/net/ethernet/mscc/ocelot_stats.c   | 236 ++++++++++++++++++++-
 drivers/net/ethernet/mscc/ocelot_vsc7514.c |   1 -
 include/soc/mscc/ocelot.h                  | 216 -------------------
 7 files changed, 228 insertions(+), 237 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2022-11-15 17:39 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-11 20:49 [PATCH v1 net-next 0/2] cleanup ocelot_stats exposure Colin Foster
2022-11-11 20:49 ` [PATCH v1 net-next 1/2] net: mscc: ocelot: remove redundant stats_layout pointers Colin Foster
2022-11-12  1:08   ` kernel test robot
2022-11-12 18:05   ` Colin Foster
2022-11-14 15:15   ` Vladimir Oltean
2022-11-15  3:43     ` Colin Foster
2022-11-15 16:08       ` Vladimir Oltean
2022-11-15 17:10         ` Colin Foster
2022-11-15 17:39           ` Vladimir Oltean
2022-11-11 20:49 ` [PATCH v1 net-next 2/2] net: mscc: ocelot: remove unnecessary exposure of stats structures Colin Foster
2022-11-12 10:34   ` kernel test robot
2022-11-14 15:19   ` Vladimir Oltean
2022-11-15  3:47     ` Colin Foster

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).