Re: [PATCH (repost) net-next] sched: add extack for tfilter_notify

Hangbin Liu
2022-11-30T08:45:29Z

On Tue, Nov 29, 2022 at 07:43:20AM -0800, Jakub Kicinski wrote:
> On Tue, 29 Nov 2022 16:07:04 +0800 Hangbin Liu wrote:
> > +unsigned int get_nlgroup(__u16 nlmsg_type)
> > +{
> > + switch (nlmsg_type) {
> > + case RTM_NEWTFILTER:
> > + case RTM_DELTFILTER:
> > + case RTM_NEWCHAIN:
> > + case RTM_DELCHAIN:
> > + case RTM_NEWTCLASS:
> > + case RTM_DELTCLASS:
> > + case RTM_NEWQDISC:
> > + case RTM_DELQDISC:
> > + case RTM_GETACTION:
> > + case RTM_NEWACTION:
> > + case RTM_DELACTION:
> > + return RTNLGRP_TC;
> > + }
>
> These are rtnl message ids, they don't belong in af_netlink.

Oh, thanks very much! Now I got what Jamal said the
"namespace collision for attributes". I will see where we should
put the new helper.

Hangbin