From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79755C433FE for ; Tue, 15 Nov 2022 17:29:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230481AbiKOR3j (ORCPT ); Tue, 15 Nov 2022 12:29:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231391AbiKOR3U (ORCPT ); Tue, 15 Nov 2022 12:29:20 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7BB029C86; Tue, 15 Nov 2022 09:29:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=MghNhBLFepqKOQwkGUfSW1GJuxjMVRFJVMazuOGss7w=; b=MbrntDhCaie5kamEI+pFVXWgke exlodypGNSNS2Bt5dkI3GpEVxZYAaiaV3mJPLkpBIxHKje72LT2DeBlTHmHl/y8CwM3B1edq/n/UG 28bJfK45ZR/yOf4v/ZSiibDhGapmDiwCxpbY1TxB8BiAPiozjuQjh7ZkiaKJ13z+7HT4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ouzjj-002Tth-P3; Tue, 15 Nov 2022 18:28:39 +0100 Date: Tue, 15 Nov 2022 18:28:39 +0100 From: Andrew Lunn To: Shenwei Wang Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jesper Dangaard Brouer , Ilias Apalodimas , Alexei Starovoitov , Daniel Borkmann , John Fastabend , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, kernel test robot Subject: Re: [PATCH v4 2/2] net: fec: add xdp and page pool statistics Message-ID: References: <20221115155744.193789-1-shenwei.wang@nxp.com> <20221115155744.193789-3-shenwei.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221115155744.193789-3-shenwei.wang@nxp.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > @@ -1582,6 +1586,7 @@ fec_enet_rx_queue(struct net_device *ndev, int budget, u16 queue_id) > struct bpf_prog *xdp_prog = READ_ONCE(fep->xdp_prog); > u32 ret, xdp_result = FEC_ENET_XDP_PASS; > u32 data_start = FEC_ENET_XDP_HEADROOM; > + u32 xdp_stats[XDP_STATS_TOTAL]; > struct xdp_buff xdp; > struct page *page; > u32 sub_len = 4; > @@ -1656,11 +1661,13 @@ fec_enet_rx_queue(struct net_device *ndev, int budget, u16 queue_id) > fec_enet_update_cbd(rxq, bdp, index); > > if (xdp_prog) { > + memset(xdp_stats, 0, sizeof(xdp_stats)); > xdp_buff_clear_frags_flag(&xdp); > /* subtract 16bit shift and FCS */ > xdp_prepare_buff(&xdp, page_address(page), > data_start, pkt_len - sub_len, false); > - ret = fec_enet_run_xdp(fep, xdp_prog, &xdp, rxq, index); > + ret = fec_enet_run_xdp(fep, xdp_prog, &xdp, rxq, > + xdp_stats, index); > xdp_result |= ret; > if (ret != FEC_ENET_XDP_PASS) > goto rx_processing_done; > @@ -1762,6 +1769,15 @@ fec_enet_rx_queue(struct net_device *ndev, int budget, u16 queue_id) > if (xdp_result & FEC_ENET_XDP_REDIR) > xdp_do_flush_map(); > > + if (xdp_prog) { > + int i; > + > + u64_stats_update_begin(&rxq->syncp); > + for (i = 0; i < XDP_STATS_TOTAL; i++) > + rxq->stats[i] += xdp_stats[i]; > + u64_stats_update_end(&rxq->syncp); > + } > + This looks wrong. You are processing upto the napi budget, 64 frames, in a loop. The memset to 0 happens inside the loop, but you do the accumulation outside the loop? This patch is getting pretty big. Please break it up, at least into one patch for XDP stats and one for page pool stats. Andrew