From: Saeed Mahameed <saeed@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jerry Ray <jerry.ray@microchip.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next][PATCH] dsa: lan9303: Changed ethtool stats
Date: Tue, 15 Nov 2022 21:00:05 -0800 [thread overview]
Message-ID: <Y3RuVUQRsiJT377E@x130.lan> (raw)
In-Reply-To: <Y3KvE+4kYUYTDzZe@lunn.ch>
On 14 Nov 22:11, Andrew Lunn wrote:
>Hi Jerry
>
>> Added a version number to the module.
>
>Don't bother, it is useless. A driver is not standalone, it depends on
>the rest of the kernel around it. Somebody telling you version 1.1 is
>broken is no help, you have no idea what version of mainline is around
>it, or if it is a backport in a vendor kernel along with 1000 other
>patches.
>
>And as a general comment, one patch should do one thing. Please break
>this up into a patchset.
>
> Andrew
Just drop the MODULE_VERSION
it's getting removed from all modules, Gregkh is always asking to remove
them.
https://lore.kernel.org/lkml/20210528092242.51104-2-eli.billauer@gmail.com/
prev parent reply other threads:[~2022-11-16 5:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 21:02 [net-next][PATCH] dsa: lan9303: Changed ethtool stats Jerry Ray
2022-11-14 21:11 ` Andrew Lunn
2022-11-16 5:00 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3RuVUQRsiJT377E@x130.lan \
--to=saeed@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jerry.ray@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).