From: Saeed Mahameed <saeed@kernel.org>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com,
Sylwester Dziedziuch <sylwesterx.dziedziuch@intel.com>,
netdev@vger.kernel.org, magnus.karlsson@intel.com,
bjorn@kernel.org, ast@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com, bpf@vger.kernel.org,
Mateusz Palczewski <mateusz.palczewski@intel.com>,
Shwetha Nagaraju <Shwetha.nagaraju@intel.com>
Subject: Re: [PATCH net 1/2] i40e: Fix failure message when XDP is configured in TX only mode
Date: Wed, 16 Nov 2022 14:29:04 -0800 [thread overview]
Message-ID: <Y3VkMPyftd//NOdp@x130.lan> (raw)
In-Reply-To: <Y3OCeXZUWpJTDIQF@boxer>
On 15 Nov 13:13, Maciej Fijalkowski wrote:
>On Mon, Nov 14, 2022 at 04:03:23PM -0800, Tony Nguyen wrote:
>> From: Sylwester Dziedziuch <sylwesterx.dziedziuch@intel.com>
>>
>> When starting xdpsock program in TX only mode:
>>
>> samples/bpf/xdpsock -i <interface> -t
>>
>> there was an error on i40e driver:
>>
>> Failed to allocate some buffers on AF_XDP ZC enabled Rx ring 0 (pf_q 81)
>>
>> It was caused by trying to allocate RX buffers even though
>> no RX buffers are available because we run in TX only mode.
>>
>> Fix this by checking for number of available buffers
>> for RX queue when allocating buffers during XDP setup.
>
>I was not sure if we want to proceed with this or not. For sure it's not a
>fix to me, behavior was not broken, txonly mode was working correctly.
>We're only getting rid of the bogus message that caused confusion within
>people.
>
>I feel that if we want that in then we should route this via -next and
>address other drivers as well. Not sure what are Magnus' thoughts on this.
>
+1
Some other driver might not have this print message issue, but it would be
nice if the driver got some indication of the TX only nature so maybe we can
cut some corners on napi and avoid even attempting to allocate the rx zc
buffers.
next prev parent reply other threads:[~2022-11-16 22:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 0:03 [PATCH net 0/2][pull request] Intel Wired LAN Driver Updates 2022-11-14 (i40e) Tony Nguyen
2022-11-15 0:03 ` [PATCH net 1/2] i40e: Fix failure message when XDP is configured in TX only mode Tony Nguyen
2022-11-15 12:13 ` Maciej Fijalkowski
2022-11-16 22:29 ` Saeed Mahameed [this message]
2022-11-17 7:09 ` Magnus Karlsson
2022-11-15 0:03 ` [PATCH net 2/2] i40e: fix xdp_redirect logs error message when testing with MTU=1500 Tony Nguyen
2022-11-15 12:27 ` Maciej Fijalkowski
2022-11-16 23:21 ` [PATCH net 0/2][pull request] Intel Wired LAN Driver Updates 2022-11-14 (i40e) Vladimir Oltean
2022-11-17 0:03 ` Maciej Fijalkowski
2022-11-17 0:24 ` Vladimir Oltean
2022-11-17 0:30 ` Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3VkMPyftd//NOdp@x130.lan \
--to=saeed@kernel.org \
--cc=Shwetha.nagaraju@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=mateusz.palczewski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sylwesterx.dziedziuch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).