* [PATCH net-next] sctp: change to include linux/sctp.h in net/sctp/checksum.h
@ 2022-11-15 15:39 Xin Long
2022-11-16 22:51 ` Saeed Mahameed
2022-11-18 6:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Xin Long @ 2022-11-15 15:39 UTC (permalink / raw)
To: network dev, linux-sctp
Cc: davem, kuba, Eric Dumazet, Paolo Abeni, Marcelo Ricardo Leitner,
Neil Horman
Currently "net/sctp/checksum.h" including "net/sctp/sctp.h" is
included in quite some places in netfilter and openswitch and
net/sched. It's not necessary to include "net/sctp/sctp.h" if
a module does not have dependence on SCTP, "linux/sctp.h" is
the right one to include.
Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
include/net/sctp/checksum.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/sctp/checksum.h b/include/net/sctp/checksum.h
index 5a9bb09f32b6..f514a0aa849e 100644
--- a/include/net/sctp/checksum.h
+++ b/include/net/sctp/checksum.h
@@ -24,7 +24,7 @@
#define __sctp_checksum_h__
#include <linux/types.h>
-#include <net/sctp/sctp.h>
+#include <linux/sctp.h>
#include <linux/crc32c.h>
#include <linux/crc32.h>
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sctp: change to include linux/sctp.h in net/sctp/checksum.h
2022-11-15 15:39 [PATCH net-next] sctp: change to include linux/sctp.h in net/sctp/checksum.h Xin Long
@ 2022-11-16 22:51 ` Saeed Mahameed
2022-11-18 6:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2022-11-16 22:51 UTC (permalink / raw)
To: Xin Long
Cc: network dev, linux-sctp, davem, kuba, Eric Dumazet, Paolo Abeni,
Marcelo Ricardo Leitner, Neil Horman
On 15 Nov 10:39, Xin Long wrote:
>Currently "net/sctp/checksum.h" including "net/sctp/sctp.h" is
>included in quite some places in netfilter and openswitch and
>net/sched. It's not necessary to include "net/sctp/sctp.h" if
>a module does not have dependence on SCTP, "linux/sctp.h" is
>the right one to include.
>
>Signed-off-by: Xin Long <lucien.xin@gmail.com>
LGTM as long as it builds:
Reviewed-by: Saeed Mahameed <saeed@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sctp: change to include linux/sctp.h in net/sctp/checksum.h
2022-11-15 15:39 [PATCH net-next] sctp: change to include linux/sctp.h in net/sctp/checksum.h Xin Long
2022-11-16 22:51 ` Saeed Mahameed
@ 2022-11-18 6:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-18 6:30 UTC (permalink / raw)
To: Xin Long
Cc: netdev, linux-sctp, davem, kuba, edumazet, pabeni,
marcelo.leitner, nhorman
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 15 Nov 2022 10:39:53 -0500 you wrote:
> Currently "net/sctp/checksum.h" including "net/sctp/sctp.h" is
> included in quite some places in netfilter and openswitch and
> net/sched. It's not necessary to include "net/sctp/sctp.h" if
> a module does not have dependence on SCTP, "linux/sctp.h" is
> the right one to include.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
>
> [...]
Here is the summary with links:
- [net-next] sctp: change to include linux/sctp.h in net/sctp/checksum.h
https://git.kernel.org/netdev/net-next/c/b78c4162823d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-18 6:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-15 15:39 [PATCH net-next] sctp: change to include linux/sctp.h in net/sctp/checksum.h Xin Long
2022-11-16 22:51 ` Saeed Mahameed
2022-11-18 6:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).