From: Saeed Mahameed <saeed@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jakub Kicinski <kuba@kernel.org>,
Daniil Tatianin <d-tatianin@yandex-team.ru>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Hao Chen <chenhao288@hisilicon.com>,
Guangbin Huang <huangguangbin2@huawei.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Marco Bonelli <marco@mebeim.net>, Tom Rix <trix@redhat.com>,
Tonghao Zhang <xiangxia.m.yue@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org, yc-core@yandex-team.ru
Subject: Re: [PATCH v1] net/ethtool/ioctl: ensure that we have phy ops before using them
Date: Wed, 16 Nov 2022 14:55:12 -0800 [thread overview]
Message-ID: <Y3VqUBUXdMrt4iAC@x130.lan> (raw)
In-Reply-To: <Y3Oy14CNVEttEI7T@lunn.ch>
On 15 Nov 16:40, Andrew Lunn wrote:
>On Mon, Nov 14, 2022 at 09:07:05PM -0800, Jakub Kicinski wrote:
>> On Mon, 14 Nov 2022 11:15:32 +0300 Daniil Tatianin wrote:
>> > + if (!(phydev && phy_ops && phy_ops->get_stats) &&
>> > + !ops->get_ethtool_phy_stats)
>>
>> This condition is still complicated.
>>
>> > + return -EOPNOTSUPP;
>>
>> The only way this crash can happen is if driver incorrectly returns
>> non-zero stats count but doesn't have a callback to read the stats.
>> So WARN_ON() would be in order here.
>
>Hi Daniil
>
>I'm missing the patch itself, and b4 does not return it. Please
same! I only see Jakub's reply, maybe the patch didn't make it through to
netdev ML ?
next prev parent reply other threads:[~2022-11-16 22:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221114081532.3475625-1-d-tatianin@yandex-team.ru>
2022-11-15 5:07 ` [PATCH v1] net/ethtool/ioctl: ensure that we have phy ops before using them Jakub Kicinski
2022-11-15 15:40 ` Andrew Lunn
2022-11-16 22:55 ` Saeed Mahameed [this message]
[not found] ` <d220e5b6-70d8-e64f-0544-d3dfaf905a6d@yandex-team.ru>
2022-11-17 12:59 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3VqUBUXdMrt4iAC@x130.lan \
--to=saeed@kernel.org \
--cc=andrew@lunn.ch \
--cc=chenhao288@hisilicon.com \
--cc=d-tatianin@yandex-team.ru \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=huangguangbin2@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=marco@mebeim.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=trix@redhat.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=xiangxia.m.yue@gmail.com \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).