netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeed@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	Dan Carpenter <error27@gmail.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH] net: ethernet: renesas: rswitch: Fix MAC address info
Date: Wed, 16 Nov 2022 15:14:53 -0800	[thread overview]
Message-ID: <Y3Vu7fOrqhHKT5hQ@x130.lan> (raw)
In-Reply-To: <20221115235519.679115-1-yoshihiro.shimoda.uh@renesas.com>

On 16 Nov 08:55, Yoshihiro Shimoda wrote:
>Smatch detected the following warning.
>
>    drivers/net/ethernet/renesas/rswitch.c:1717 rswitch_init() warn:
>    '%pM' cannot be followed by 'n'
>
>The 'n' should be '\n'.
>
>Reported-by: Dan Carpenter <error27@gmail.com>
>Suggested-by: Geert Uytterhoeven <geert+renesas@glider.be>
>Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")

I would drop the Fixes tag, this shoiuldn't go to net and -stable. 
and please tag either [PATCH net] or [PATCH net-next], this one should be
net-next.

Thanks,
you can add:
Reviewed-by: Saeed Mahameed <saeed@kernel.org>


  reply	other threads:[~2022-11-16 23:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-15 23:55 [PATCH] net: ethernet: renesas: rswitch: Fix MAC address info Yoshihiro Shimoda
2022-11-16 23:14 ` Saeed Mahameed [this message]
2022-11-16 23:35   ` Vladimir Oltean
2022-11-17  8:57     ` Yoshihiro Shimoda
2022-11-17  3:58   ` Dan Carpenter
2022-11-17  4:10     ` Dan Carpenter
2022-11-17  6:09 ` Leon Romanovsky
2022-11-17  8:58   ` Yoshihiro Shimoda
2022-11-17  8:59     ` Geert Uytterhoeven
2022-11-17  9:14       ` Leon Romanovsky
2022-11-17  9:38         ` Geert Uytterhoeven
2022-11-17 10:54           ` Leon Romanovsky
2022-11-18  0:16           ` Yoshihiro Shimoda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3Vu7fOrqhHKT5hQ@x130.lan \
    --to=saeed@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=error27@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=kuba@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).