From: Saeed Mahameed <saeed@kernel.org>
To: Jeroen de Borst <jeroendb@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
jesse.brandeburg@intel.com
Subject: Re: [PATCH net-next v3 2/2] gve: Handle alternate miss completions
Date: Wed, 16 Nov 2022 15:36:08 -0800 [thread overview]
Message-ID: <Y3Vz6BIlgE92hsA4@x130.lan> (raw)
In-Reply-To: <CAErkTsQALv3NL2jvFY1xgaXsWCPtavZP1UTgDcqo-YBdQCyjzQ@mail.gmail.com>
On 16 Nov 08:23, Jeroen de Borst wrote:
>Saeed,
>
>Thanks for your review. I like the suggestion, but
>__test_and_clear_bit is for unsigned longs, comptag is a short.
>
gcc will up-cast it for you with no problem.
Assuming it's unsigned short.. if not then consider changing it to unsigned
short, or do the casting yourself.
anyway this was just a minor suggestion.
next prev parent reply other threads:[~2022-11-16 23:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 23:35 [PATCH net-next v3 0/2] gve: Handle alternate miss-completions Jeroen de Borst
2022-11-14 23:35 ` [PATCH net-next v3 1/2] gve: Adding a new AdminQ command to verify driver Jeroen de Borst
2022-11-16 5:34 ` Saeed Mahameed
2022-11-14 23:35 ` [PATCH net-next v3 2/2] gve: Handle alternate miss completions Jeroen de Borst
2022-11-16 5:17 ` Saeed Mahameed
2022-11-16 16:23 ` Jeroen de Borst
2022-11-16 23:36 ` Saeed Mahameed [this message]
2022-11-16 5:38 ` [PATCH net-next v3 0/2] gve: Handle alternate miss-completions Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3Vz6BIlgE92hsA4@x130.lan \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=jeroendb@google.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).