From: Hangbin Liu <liuhangbin@gmail.com>
To: Jay Vosburgh <jay.vosburgh@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Jonathan Toppins <jtoppins@redhat.com>,
Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@gmail.com>,
Liang Li <liali@redhat.com>, David Ahern <dsahern@kernel.org>
Subject: Re: [PATCHv3 net] bonding: fix ICMPv6 header handling when receiving IPv6 messages
Date: Thu, 17 Nov 2022 16:34:32 +0800 [thread overview]
Message-ID: <Y3XyGIVnX2xvZ/bU@Laptop-X1> (raw)
In-Reply-To: <22985.1668659398@famine>
On Wed, Nov 16, 2022 at 08:29:58PM -0800, Jay Vosburgh wrote:
> > #if IS_ENABLED(CONFIG_IPV6)
> >- } else if (is_ipv6) {
> >+ } else if (is_ipv6 && skb_header_pointer(skb, 0, sizeof(ip6_hdr), &ip6_hdr)) {
> > return bond_na_rcv(skb, bond, slave);
> > #endif
> > } else {
> >
> >What do you think?
>
> I don't see how this solves the icmp6_hdr() / ipv6_hdr() problem
> in bond_na_rcv(); skb_header_pointer() doesn't do a pull, it just copies
> into the supplied struct (if necessary).
Hmm... Maybe I didn't get what you and Eric means. If we can copy the
supplied buffer success, doesn't this make sure IPv6 header is in skb?
Thanks
Hangbin
next prev parent reply other threads:[~2022-11-17 8:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 1:40 [PATCHv3 net] bonding: fix ICMPv6 header handling when receiving IPv6 messages Hangbin Liu
2022-11-09 19:42 ` Jay Vosburgh
2022-11-09 20:17 ` Eric Dumazet
2022-11-09 20:39 ` Jay Vosburgh
2022-11-09 20:45 ` Eric Dumazet
2022-11-09 21:23 ` Jay Vosburgh
2022-11-09 21:48 ` Eric Dumazet
2022-11-16 6:34 ` Hangbin Liu
2022-11-16 15:16 ` Jay Vosburgh
2022-11-17 2:44 ` Hangbin Liu
2022-11-17 4:29 ` Jay Vosburgh
2022-11-17 8:34 ` Hangbin Liu [this message]
2022-11-17 10:27 ` Eric Dumazet
2022-11-17 20:04 ` Jay Vosburgh
2022-11-18 2:49 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3XyGIVnX2xvZ/bU@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=jay.vosburgh@canonical.com \
--cc=jtoppins@redhat.com \
--cc=kuba@kernel.org \
--cc=liali@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox