netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Andrew Lunn <andrew@lunn.ch>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-arm-msm@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-iio@vger.kernel.org, linux-input@vger.kernel.org,
	linux-leds@vger.kernel.org, linux-media@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, netdev@vger.kernel.org,
	linux-can@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org,
	linux-serial@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-spi@vger.kernel.org, linux-usb@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	linux-watchdog@vger.kernel.org
Subject: Re: [RFC PATCH 1/9] dt-bindings: drop redundant part of title of shared bindings
Date: Thu, 17 Nov 2022 17:52:03 +0000	[thread overview]
Message-ID: <Y3Z0w6JH1f5zgwvW@spud> (raw)
In-Reply-To: <20221117123850.368213-2-krzysztof.kozlowski@linaro.org>

On Thu, Nov 17, 2022 at 01:38:42PM +0100, Krzysztof Kozlowski wrote:
> The Devicetree bindings document does not have to say in the title that
> it is a "binding", but instead just describe the hardware.  For shared
> (re-usable) schemas, name them all as "common properties".


> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> index 1ab416c83c8d..d2de3d128b73 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/clock/qcom,gcc.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Qualcomm Global Clock & Reset Controller Common Bindings
> +title: Qualcomm Global Clock & Reset Controller common parts
>  
>  maintainers:
>    - Stephen Boyd <sboyd@kernel.org>


> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> index cf9c2f7bddc2..20ac432dc683 100644
> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/opp/opp-v2-base.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Generic OPP (Operating Performance Points) Common Binding
> +title: Generic OPP (Operating Performance Points) common parts
>  
>  maintainers:
>    - Viresh Kumar <viresh.kumar@linaro.org>

Hey Krzysztof,

Hopefully I've not overlooked something obvious, but it wasnt noted in
the commit message - how come these two are "parts" rather than
"properties"? The opp one at least don't seem to have much more than
properties and patterProperties in it.

Thanks,
Conor.


  parent reply	other threads:[~2022-11-17 17:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 12:38 [RFC PATCH 0/9] dt-bindings: cleanup titles Krzysztof Kozlowski
2022-11-17 12:38 ` [RFC PATCH 1/9] dt-bindings: drop redundant part of title of shared bindings Krzysztof Kozlowski
2022-11-17 13:23   ` Andrew Lunn
2022-11-17 14:58     ` Krzysztof Kozlowski
2022-11-17 14:33   ` Guenter Roeck
2022-11-17 15:17   ` Jonathan Cameron
2022-11-17 17:19   ` Rob Herring
2022-11-17 17:38     ` Krzysztof Kozlowski
2022-11-17 17:52   ` Conor Dooley [this message]
2022-11-18  8:27     ` Krzysztof Kozlowski
2022-11-17 21:07   ` Miquel Raynal
2022-11-18  8:28     ` Krzysztof Kozlowski
2022-11-17 12:38 ` [RFC PATCH 2/9] dt-bindings: memory-controllers: ti,gpmc-child: drop redundant part of title Krzysztof Kozlowski
2022-11-17 12:38 ` [RFC PATCH 3/9] dt-bindings: clock: st,stm32mp1-rcc: add proper title Krzysztof Kozlowski
2022-11-17 12:38 ` [RFC PATCH 4/9] dt-bindings: drop redundant part of title (end) Krzysztof Kozlowski
2022-11-17 15:18   ` Jonathan Cameron
2022-11-17 15:37   ` Jonathan Cameron
2022-11-17 12:38 ` [RFC PATCH 5/9] dt-bindings: drop redundant part of title (end, part two) Krzysztof Kozlowski
2022-11-17 15:58   ` Jonathan Cameron
2022-11-17 12:38 ` [RFC PATCH 6/9] dt-bindings: drop redundant part of title (end, part three) Krzysztof Kozlowski
2022-11-17 12:38 ` [RFC PATCH 7/9] dt-bindings: drop redundant part of title (beginning) Krzysztof Kozlowski
2022-11-17 16:01   ` Jonathan Cameron
2022-11-17 12:38 ` [RFC PATCH 8/9] dt-bindings: clock: drop redundant part of title Krzysztof Kozlowski
2022-11-17 16:03   ` Jonathan Cameron
2022-11-17 12:38 ` [RFC PATCH 9/9] dt-bindings: drop redundant part of title (manual) Krzysztof Kozlowski
2022-11-17 16:05   ` Jonathan Cameron
2022-11-17 16:13 ` [RFC PATCH 0/9] dt-bindings: cleanup titles Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3Z0w6JH1f5zgwvW@spud \
    --to=conor@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).