From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4280BC433FE for ; Fri, 18 Nov 2022 10:29:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241709AbiKRK3b (ORCPT ); Fri, 18 Nov 2022 05:29:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235171AbiKRK3a (ORCPT ); Fri, 18 Nov 2022 05:29:30 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1C47D18B3D; Fri, 18 Nov 2022 02:29:29 -0800 (PST) Date: Fri, 18 Nov 2022 11:29:25 +0100 From: Pablo Neira Ayuso To: Daniel Xu Cc: fw@strlen.de, kadlec@netfilter.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] netfilter: ctmark: Fix data-races around ctmark Message-ID: References: <7220acad9aaefa2ab891d1bcbbc9d5cc4a8f0a7e.1668022522.git.dxu@dxuuu.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7220acad9aaefa2ab891d1bcbbc9d5cc4a8f0a7e.1668022522.git.dxu@dxuuu.xyz> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Nov 09, 2022 at 12:39:07PM -0700, Daniel Xu wrote: > nf_conn:mark can be read from and written to in parallel. Use > READ_ONCE()/WRITE_ONCE() for reads and writes to prevent unwanted > compiler optimizations. > > Signed-off-by: Daniel Xu > --- > Changes since v1: > - Remove WRITE_ONCE() from init path > > net/core/flow_dissector.c | 2 +- > net/ipv4/netfilter/ipt_CLUSTERIP.c | 4 ++-- > net/netfilter/nf_conntrack_core.c | 2 +- > net/netfilter/nf_conntrack_netlink.c | 24 ++++++++++++++---------- > net/netfilter/nf_conntrack_standalone.c | 2 +- > net/netfilter/nft_ct.c | 6 +++--- > net/netfilter/xt_connmark.c | 18 ++++++++++-------- > net/openvswitch/conntrack.c | 8 ++++---- > net/sched/act_connmark.c | 4 ++-- > net/sched/act_ct.c | 8 ++++---- > net/sched/act_ctinfo.c | 6 +++--- > 11 files changed, 45 insertions(+), 39 deletions(-) I am going to place this in nf.git, it's a bit late but it's relatively small and I think the sooner the better to have this fix.