From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Goh, Wei Sheng" <wei.sheng.goh@intel.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Ong Boon Leong <boon.leong.ong@intel.com>,
Voon Wei Feng <weifeng.voon@intel.com>,
Tan Tee Min <tee.min.tan@intel.com>,
Ahmad Tarmizi Noor Azura <noor.azura.ahmad.tarmizi@intel.com>,
Looi Hong Aun <hong.aun.looi@intel.com>
Subject: Re: [PATCH net] net: stmmac: Set MAC's flow control register to reflect current settings
Date: Fri, 18 Nov 2022 11:16:26 +0000 [thread overview]
Message-ID: <Y3dpikbzUJAazMTD@shell.armlinux.org.uk> (raw)
In-Reply-To: <20221118072051.31313-1-wei.sheng.goh@intel.com>
On Fri, Nov 18, 2022 at 03:20:51PM +0800, Goh, Wei Sheng wrote:
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 8273e6a175c8..ab7f48f32f5b 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -1061,8 +1061,16 @@ static void stmmac_mac_link_up(struct phylink_config *config,
> ctrl |= priv->hw->link.duplex;
>
> /* Flow Control operation */
> - if (tx_pause && rx_pause)
> - stmmac_mac_flow_ctrl(priv, duplex);
> + if (rx_pause && tx_pause)
> + priv->flow_ctrl = FLOW_AUTO;
> + else if (rx_pause && !tx_pause)
> + priv->flow_ctrl = FLOW_RX;
> + else if (!rx_pause && tx_pause)
> + priv->flow_ctrl = FLOW_TX;
> + else if (!rx_pause && !tx_pause)
> + priv->flow_ctrl = FLOW_OFF;
Since "if (!rx_pause && !tx_pause)" will always be true at this point,
you can eliminate this needless last condition, which will make the code
a little more readable.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2022-11-18 11:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 7:20 [PATCH net] net: stmmac: Set MAC's flow control register to reflect current settings Goh, Wei Sheng
2022-11-18 11:16 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3dpikbzUJAazMTD@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.torgue@st.com \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hong.aun.looi@intel.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=noor.azura.ahmad.tarmizi@intel.com \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=tee.min.tan@intel.com \
--cc=wei.sheng.goh@intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).