* [PATCH net] net: phy: at803x: fix error return code in at803x_probe()
@ 2022-11-18 10:36 Wei Yongjun
2022-11-18 13:21 ` Andrew Lunn
2022-11-22 5:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2022-11-18 10:36 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Robert Hancock
Cc: Wei Yongjun, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix to return a negative error code from the ccr read error handling
case instead of 0, as done elsewhere in this function.
Fixes: 3265f4218878 ("net: phy: at803x: add fiber support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
resend with [PATCH net] prefix
drivers/net/phy/at803x.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 349b7b1dbbf2..d49965907561 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -870,8 +870,10 @@ static int at803x_probe(struct phy_device *phydev)
.wolopts = 0,
};
- if (ccr < 0)
+ if (ccr < 0) {
+ ret = ccr;
goto err;
+ }
mode_cfg = ccr & AT803X_MODE_CFG_MASK;
switch (mode_cfg) {
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: phy: at803x: fix error return code in at803x_probe()
2022-11-18 10:36 [PATCH net] net: phy: at803x: fix error return code in at803x_probe() Wei Yongjun
@ 2022-11-18 13:21 ` Andrew Lunn
2022-11-22 5:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2022-11-18 13:21 UTC (permalink / raw)
To: Wei Yongjun
Cc: Heiner Kallweit, Russell King, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Robert Hancock, Wei Yongjun, netdev
On Fri, Nov 18, 2022 at 10:36:35AM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return a negative error code from the ccr read error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 3265f4218878 ("net: phy: at803x: add fiber support")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> resend with [PATCH net] prefix
In future, please always increment the version number of the patch.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: phy: at803x: fix error return code in at803x_probe()
2022-11-18 10:36 [PATCH net] net: phy: at803x: fix error return code in at803x_probe() Wei Yongjun
2022-11-18 13:21 ` Andrew Lunn
@ 2022-11-22 5:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-22 5:00 UTC (permalink / raw)
To: Wei Yongjun
Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni,
robert.hancock, weiyongjun1, netdev
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 18 Nov 2022 10:36:35 +0000 you wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return a negative error code from the ccr read error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 3265f4218878 ("net: phy: at803x: add fiber support")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> [...]
Here is the summary with links:
- [net] net: phy: at803x: fix error return code in at803x_probe()
https://git.kernel.org/netdev/net/c/1f0dd412e34e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-22 5:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-18 10:36 [PATCH net] net: phy: at803x: fix error return code in at803x_probe() Wei Yongjun
2022-11-18 13:21 ` Andrew Lunn
2022-11-22 5:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).